Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change zbox get to zbox getallocation #509

Merged
merged 1 commit into from
Jan 22, 2023
Merged

change zbox get to zbox getallocation #509

merged 1 commit into from
Jan 22, 2023
+1 −1

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Jan 15, 2023 •
edited
Loading

@boddumanohar boddumanohar marked this pull request as ready for review January 15, 2023 11:38
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests zboxget
gosdk staging
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests zboxget
gosdk staging
zboxcli zbox-get
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

Kishan-Dhakan
Kishan-Dhakan approved these changes Jan 22, 2023
View reviewed changes
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge with corresponding zbox PR

@boddumanohar boddumanohar mentioned this pull request Jan 22, 2023
Merged
3 tasks
@boddumanohar
Copy link
Contributor Author

@Kishan-Dhakan updated the zbox PR in the PR description. thanks.

@Kishan-Dhakan Kishan-Dhakan merged commit 77bf3b6 into master Jan 22, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the zboxget branch January 22, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

@stewartie4 stewartie4 Awaiting requested review from stewartie4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boddumanohar @service-0chain @Kishan-Dhakan