V5 Decimal numeric type in Move Vm #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
0o-de-lally
commented
Aug 28, 2021
•
0o-de-lally
commented
- native function in move_vm including rust_decimal (rust)
- tests for rust_decimal native (rust)
- tests for casting and rounding large integers and irrationals (rust)
- Move module Decimal.move
- Decimal Struct for Move
- functional tests for Decimal round trip from move to rust.
- APIs for simple arithmetic operations add, sub, mul, div
- power
- square root
- test for polynomials
5 tasks
0o-de-lally
added a commit
that referenced
this pull request
Sep 21, 2021
* add decimal native * ol_decimal.rs tests * decimal irrational number test * change move decimal type to u128 to use throughout. * patch negative number casting
0o-de-lally
added a commit
that referenced
this pull request
Sep 22, 2021
* add decimal native * ol_decimal.rs tests * decimal irrational number test * change move decimal type to u128 to use throughout. * patch negative number casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.