Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders #292

Merged
merged 15 commits into from
Jul 22, 2024
Merged

[move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders #292

merged 15 commits into from
Jul 22, 2024

Conversation

soaresa
Copy link
Contributor

@soaresa soaresa commented Jul 19, 2024 •
edited
Loading

This PR includes features, fixes, and refactors mainly related to the Proof of Fee module:

Move Test Coverage:

Test Coverage Overall Score % #Tests
Before 68.52 303
After 70.08 349
Diff. 1.56 46

Move Test Coverage Score per Module:

Module Before After Diff
address_utils - 100.00 100.00
pledge_accounts 5.92 32.42 26.50
infra_escrow 27.27 47.73 20.46
musical_chairs 75.74 79.50 3.76
burn 58.00 61.50 3.50
randomness 44.27 44.71 0.44
genesis 47.84 48.14 0.30

@soaresa
shuffles validators with same bid value
629db21
@soaresa
reduces val set for competition between qualified bidders having 21 o…
c190c67 
…r more compliant
@soaresa
initializes randomness on ol_reconfigure_for_test
7b6321a
@soaresa
refactors musical chairs mod and adds more tests
315ce79
@soaresa
gitignore target folders, and move coverage files
fa74773
@soaresa
fixes reward thermostat call order - WIP
1939fb5 
clean up code
@soaresa
fix budget to collect, and fee calculus
f17e9c2 
test subsidy, fees and reward payments
@soaresa
test subsidy and rewards having a non compliant val
e633c18
@soaresa
test that entry fee sum is burnt on epoch trigger
58180fa
@soaresa
adds tests to reward_thermostat increasing and decreasing rewards
24c6aba 
fixes tests broken by mock changes
@soaresa
extracts pure function from reward_thermostat and adds tests
63d1a00 
creates view query_reward_adjustment
@soaresa
fixes persist_genesis smoke test
441b973
@soaresa
applies rlint
56d66ae
@soaresa soaresa changed the title Breaking/pof tiebreaker cherry pick [move] PoF tiebreaker randomize tied bids, maintain fewer seats than bidders Jul 19, 2024
@soaresa soaresa linked an issue Jul 19, 2024 that may be closed by this pull request
PoF issue with equal bids for lowest, and set sizes equal to bidders #251
Closed
@soaresa soaresa requested a review from 0o-de-lally July 22, 2024 00:02
@soaresa soaresa marked this pull request as ready for review July 22, 2024 00:02
0o-de-lally
0o-de-lally approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@0o-de-lally 0o-de-lally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOT killer PR

@0o-de-lally 0o-de-lally merged commit 3958b87 into 0LNetworkCommunity:main Jul 22, 2024
12 checks passed
sirouk
sirouk reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@sirouk sirouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@soaresa soaresa mentioned this pull request Aug 5, 2024
Merged
@soaresa soaresa mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirouk sirouk sirouk left review comments

@0o-de-lally 0o-de-lally 0o-de-lally approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PoF issue with equal bids for lowest, and set sizes equal to bidders
3 participants
@soaresa @0o-de-lally @sirouk