[Hub Generated] Review request for Microsoft.VirtualMachineImages to …

…add version stable/2020-02-14 (Azure#9297) * Update examples to include identity in requests/responses * Make identity field a required field for image template resource * Update to have POST /run & /cancel to return 200 code for powershell sdk generation * Update description of 200 code Co-authored-by: Feiyu Shi <[email protected]>
00Kai0 · Oct 12, 2020 · b09e983 · b09e983
1 parent 9ba75b3
commit b09e983
Show file tree

Hide file tree

Showing 10 changed files with 114 additions and 145 deletions.
diff --git a/...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CancelImageBuild.json b/...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CancelImageBuild.json
@@ -6,6 +6,7 @@
     "api-version": "2020-02-14"
   },
   "responses": {
+    "200": {},
     "204": {},
     "202": {
       "headers": {

diff --git a/...r/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CreateImageTemplateLinux.json b/...r/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CreateImageTemplateLinux.json
@@ -10,6 +10,12 @@
         "imagetemplate_tag1": "IT_T1",
         "imagetemplate_tag2": "IT_T2"
       },
+      "identity": {
+        "type": "UserAssigned",
+        "userAssignedIdentities": {
+          "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {}
+        }
+      },
       "properties": {
         "source": {
           "type": "ManagedImage",
@@ -50,6 +56,15 @@
         "name": "myImageTemplate",
         "location": "westus",
         "type": "Microsoft.VirtualMachineImages/imageTemplate",
+        "identity": {
+          "type": "UserAssigned",
+          "userAssignedIdentities": {
+            "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+              "clientId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000"
+            }
+          }
+        },
         "properties": {
           "source": {
             "type": "ManagedImage",
@@ -89,6 +104,15 @@
         "name": "myImageTemplate",
         "location": "westus",
         "type": "Microsoft.VirtualMachineImages/imageTemplate",
+        "identity": {
+          "type": "UserAssigned",
+          "userAssignedIdentities": {
+            "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+              "clientId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000"
+            }
+          }
+        },
         "properties": {
           "source": {
             "type": "ManagedImage",

diff --git a/...Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CreateImageTemplateWindows.json b/...Microsoft.VirtualMachineImages/stable/2020-02-14/examples/CreateImageTemplateWindows.json
@@ -10,6 +10,12 @@
         "imagetemplate_tag1": "IT_T1",
         "imagetemplate_tag2": "IT_T2"
       },
+      "identity": {
+        "type": "UserAssigned",
+        "userAssignedIdentities": {
+          "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {}
+        }
+      },
       "properties": {
         "source": {
           "type": "ManagedImage",
@@ -79,6 +85,15 @@
         "name": "myImageTemplate",
         "location": "westus",
         "type": "Microsoft.VirtualMachineImages/imageTemplate",
+        "identity": {
+          "type": "UserAssigned",
+          "userAssignedIdentities": {
+            "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+              "clientId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000"
+            }
+          }
+        },
         "properties": {
           "source": {
             "type": "ManagedImage",
@@ -118,6 +133,15 @@
         "name": "myImageTemplate",
         "location": "westus",
         "type": "Microsoft.VirtualMachineImages/imageTemplate",
+        "identity": {
+          "type": "UserAssigned",
+          "userAssignedIdentities": {
+            "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+              "clientId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000"
+            }
+          }
+        },
         "properties": {
           "source": {
             "type": "ManagedImage",

diff --git a/...MachineImages/stable/2020-02-14/examples/CreateImageTemplateWithUserAssignedIdentity.json b/...MachineImages/stable/2020-02-14/examples/CreateImageTemplateWithUserAssignedIdentity.json
diff --git a/...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/GetImageTemplate.json b/...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/GetImageTemplate.json
@@ -12,6 +12,15 @@
         "name": "myImageTemplate",
         "location": "westus",
         "type": "Microsoft.VirtualMachineImages/imageTemplate",
+        "identity": {
+          "type": "UserAssigned",
+          "userAssignedIdentities": {
+            "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+              "clientId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000"
+            }
+          }
+        },
         "properties": {
           "source": {
             "type": "ManagedImage",

diff --git a/...manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/ListImageTemplates.json b/...manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/ListImageTemplates.json
@@ -12,6 +12,15 @@
             "name": "myImageTemplate",
             "location": "westus",
             "type": "Microsoft.VirtualMachineImages/imageTemplate",
+            "identity": {
+              "type": "UserAssigned",
+              "userAssignedIdentities": {
+                "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+                  "clientId": "00000000-0000-0000-0000-000000000000",
+                  "principalId": "00000000-0000-0000-0000-000000000000"
+                }
+              }
+            },
             "properties": {
               "source": {
                 "type": "ManagedImage",
@@ -46,6 +55,15 @@
             "name": "mySecondImageTemplate",
             "location": "westus",
             "type": "Microsoft.VirtualMachineImages/imageTemplate",
+            "identity": {
+              "type": "UserAssigned",
+              "userAssignedIdentities": {
+                "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+                  "clientId": "00000000-0000-0000-0000-000000000000",
+                  "principalId": "00000000-0000-0000-0000-000000000000"
+                }
+              }
+            },
             "properties": {
               "source": {
                 "type": "PlatformImage",

diff --git a/...ger/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/ListImageTemplatesByRg.json b/...ger/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/ListImageTemplatesByRg.json
@@ -13,6 +13,15 @@
             "name": "myImageTemplate",
             "location": "westus",
             "type": "Microsoft.VirtualMachineImages/imageTemplate",
+            "identity": {
+              "type": "UserAssigned",
+              "userAssignedIdentities": {
+                "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+                  "clientId": "00000000-0000-0000-0000-000000000000",
+                  "principalId": "00000000-0000-0000-0000-000000000000"
+                }
+              }
+            },
             "properties": {
               "source": {
                 "type": "ManagedImage",
@@ -47,6 +56,15 @@
             "name": "myOtherImageTemplate",
             "location": "eastus",
             "type": "Microsoft.VirtualMachineImages/imageTemplate",
+            "identity": {
+              "type": "UserAssigned",
+              "userAssignedIdentities": {
+                "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+                  "clientId": "00000000-0000-0000-0000-000000000000",
+                  "principalId": "00000000-0000-0000-0000-000000000000"
+                }
+              }
+            },
             "properties": {
               "source": {
                 "type": "PlatformImage",

diff --git a/...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/RunImageTemplate.json b/...e-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/RunImageTemplate.json
@@ -11,6 +11,7 @@
         "Azure-AsyncOperation": "https://management.azure.com/subscriptions/{subscription-id}/providers/Microsoft.VirtualMachineImages/locations/{location}/operations/{operation-id}?api-version=2020-02-14"
       }
     },
-    "204": {}
+    "204": {},
+    "200": {}
   }
 }
diff --git a/...er/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/UpdateImageTemplateTags.json b/...er/Microsoft.VirtualMachineImages/stable/2020-02-14/examples/UpdateImageTemplateTags.json
@@ -20,6 +20,15 @@
         "tags": {
           "new-tag": "new-value"
         },
+        "identity": {
+          "type": "UserAssigned",
+          "userAssignedIdentities": {
+            "/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/rg1/providers/Microsoft.ManagedIdentity/userAssignedIdentities/identity_1": {
+              "clientId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000"
+            }
+          }
+        },
         "properties": {
           "source": {
             "type": "ManagedImage",

diff --git a/...ilder/resource-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/imagebuilder.json b/...ilder/resource-manager/Microsoft.VirtualMachineImages/stable/2020-02-14/imagebuilder.json
@@ -175,9 +175,6 @@
           },
           "Create an Image Template for Windows.": {
             "$ref": "./examples/CreateImageTemplateWindows.json"
-          },
-          "Create an Image Template with a user assigned identity configured": {
-            "$ref": "./examples/CreateImageTemplateWithUserAssignedIdentity.json"
           }
         }
       },
@@ -350,6 +347,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "The operation was successful."
+          },
           "204": {
             "description": "The operation was successful."
           },
@@ -396,6 +396,9 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "The operation was successful."
+          },
           "204": {
             "description": "The long running image build has been canceled."
           },
@@ -1162,6 +1165,9 @@
         {
           "$ref": "#/definitions/Resource"
         }
+      ],
+      "required": [
+        "identity"
       ]
     },
     "ImageTemplateUpdateParameters": {