-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CD] Dockerize All Services, Improve CI Scripts #31
Conversation
BREAKING CHANGE: docker-compose scripts are changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits and questions.
console.log(e) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? Don't think our other use cases are logging errors since it's handled by Hono's global error handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah whoops, this was for debugging. I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe your changes
README.md
at project root in order to easily onboard developersdocker-compose up
commandbun run test
will now run in an isolated Docker environment for testingType instantiation is excessively deep and possibly infinite
error thanks to Zod 3.22.2 TS 5.2.2: TS2589: Type instantiation is excessively deep and possibly infinite colinhacks/zod#2697 (comment)Checklist before requesting a review
Testing
I've tested on a clean clone and here's how you can too:
Then visit
localhost:5173
to test the client application.