Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CD] Dockerize All Services, Improve CI Scripts #31

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

Luzefiru
Copy link
Collaborator

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.

Testing

I've tested on a clean clone and here's how you can too:

git clone [email protected]:0-BSCode/Budgeteer.git
cd Budgeteer/
git checkout cd--docker-compose

# run all services at once
bun run all:up

Then visit localhost:5173 to test the client application.

@Luzefiru Luzefiru added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 25, 2024
@Luzefiru Luzefiru requested a review from 0-BSCode November 25, 2024 14:53
Copy link
Owner

@0-BSCode 0-BSCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits and questions.

Comment on lines 56 to 57
console.log(e)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? Don't think our other use cases are logging errors since it's handled by Hono's global error handler

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah whoops, this was for debugging. I'll remove it.

package.json Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
@Luzefiru Luzefiru requested a review from 0-BSCode November 26, 2024 01:27
Copy link
Owner

@0-BSCode 0-BSCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luzefiru Luzefiru merged commit c7e4609 into main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants