Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streams upgrade in RAFT handle (RMM backend + create handle from parent's pool) #148

Merged
merged 7 commits into from
Feb 22, 2021
Merged

Streams upgrade in RAFT handle (RMM backend + create handle from parent's pool) #148

merged 7 commits into from
Feb 22, 2021

Conversation

afender
Copy link
Member

@afender afender commented Feb 11, 2021

Close #141
Close #142

Add:

  • RMM pool backends for handle's internal streams
  • Feature to get a new handle from an existing handle by specifying a stream in the parent's pool
  • Keep previous accessors so that no change is needed in existing codes
  • Additional accessors exposing rmm::cuda_stream_view for convenience (comes with is_default() and synchronize() features from rmm)

Verified that creating a light handle from a parent handle is very inexpensive (microseconds).

Needed for rapidsai/cugraph#957

@afender afender added enhancement New feature or request 3 - Ready for Review non-breaking Non-breaking change labels Feb 11, 2021
@afender afender self-assigned this Feb 11, 2021
@afender afender added improvement Improvement / enhancement to an existing function and removed enhancement New feature or request labels Feb 11, 2021
seunghwak
seunghwak reviewed Feb 12, 2021
View reviewed changes
cpp/include/raft/handle.hpp Show resolved Hide resolved
cpp/include/raft/handle.hpp Outdated Show resolved Hide resolved
cpp/include/raft/handle.hpp Outdated Show resolved Hide resolved
@afender afender changed the title Streams upgrade in RAFT handle (RMM backend + get_handle_from_pool) Streams upgrade in RAFT handle (RMM backend + create handle parent's pool) Feb 12, 2021
@afender afender changed the title Streams upgrade in RAFT handle (RMM backend + create handle parent's pool) Streams upgrade in RAFT handle (RMM backend + create handle from parent's pool) Feb 12, 2021
@afender afender requested a review from seunghwak February 12, 2021 18:42
cjnolet
cjnolet approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet merged commit 43ecde4 into rapidsai:branch-0.19 Feb 22, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

dantegd pushed a commit to dantegd/raft that referenced this pull request Jul 23, 2024
@tfeher
Accept host_mdspan for IVF-PQ build and extend (rapidsai#148)
1912355 
This PR enables host input arrays for `ivf_pq::build` and `ivf_pq::extend`.

closes rapidsai#120 
closes rapidsai#143

Authors:
  - Tamas Bela Feher (https://github.com/tfeher)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai/cuvs#148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@cjnolet cjnolet cjnolet approved these changes

@teju85 teju85 Awaiting requested review from teju85

Assignees

@afender afender

Labels
3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
4 participants
@afender @BradReesWork @cjnolet @seunghwak