Obsolete crc32 and use a internal copy #57
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type
Crc32
is currently public, but it should not be.The reasons are that this is a type that is only used as a "helper", and that this library is not dealing with hashing funtions per-se and hence should not publicly expose any.
Since we cannot delete (or internalise) a public type without introducing a breaking change, I marked the type as
Obsolete
to discourage its use by consumers of this library, and created aninternal sealed class InternalCrc32
as internal replacement.The original
Crc32
can go out of service when the next breaking changes are introduced.