Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NetStandart Load with proxy problem #59

Closed
cacheoff opened this issue Aug 1, 2017 · 6 comments
Closed

.NetStandart Load with proxy problem #59

cacheoff opened this issue Aug 1, 2017 · 6 comments
Assignees

Comments

@cacheoff
Copy link

cacheoff commented Aug 1, 2017

In a Task.Run statement when we use HtmlWeb.Load() with IWebProxy and ICredentials parameters Task.Run statement never hits.

@JonathanMagnan JonathanMagnan self-assigned this Aug 2, 2017
@JonathanMagnan
Copy link
Member

Hello @cacheoff ,

Thank you for reporting,

We will look at this issue very soon.

Best Regards,

Jonathan

@JonathanMagnan
Copy link
Member

Hello @cacheoff ,

A new version has been released v1.5.2-beta4,

We removed some code that was calling await for nothing and make sure to add ConfigureAwait(false) everywhere.

Let me know if we fixed deadlock caused by the library.

Best Regards,

Jonathan

@cacheoff
Copy link
Author

cacheoff commented Aug 3, 2017 via email

@JonathanMagnan
Copy link
Member

Which version of .NET Standard are you using?

I don't remember the link, but I have heard of such issue in .NET Standard 1.3

Best Regards,

Jonathan

@cacheoff
Copy link
Author

cacheoff commented Aug 3, 2017

I was using .NetStandard 1.5. But because of that issue I converted my project to .NetFramework 4.6. Now i have no problem anymore. Everything works properly.

@JonathanMagnan
Copy link
Member

Yup, that's why I released a version for .NET Standard 1.6

When I have asked to MysticMind (https://github.com/mysticmind/mysticmind-htmlagilitypack) which is the one that made almost all the code to support .NET Standard, he answering me this:

When I tried with NetStandard 1.3, it resulted in several errors pertaining to System.Net.Http and others. Then I read some material online and found out that NetStandard 1.6 has better support covering more surface area of libraries, it which readily worked with few tweaks/changes.

I still released a version for 1.3 since some people wanted to only use it without loading the HTML directly from the web.

I will close this issue then since you moved back to .NET Framework 4.6 and anyway, I don't think there is something I can really do.

Best Regards,

Jonathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants