Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp gate support for QASMParser #153

Closed
rahulsust opened this issue Sep 8, 2023 · 4 comments · Fixed by #156
Closed

cp gate support for QASMParser #153

rahulsust opened this issue Sep 8, 2023 · 4 comments · Fixed by #156

Comments

@rahulsust
Copy link

rahulsust commented Sep 8, 2023

Hi @jvdwetering, I faced the problem of phase(p), and controlled phase(cp) gate when parsing the qasm string. I thought I might try working on this issue to add p and cp gate support. Your guidance and input would be greatly appreciated.

@jvdwetering
Copy link
Collaborator

I think @dlyongemallo might have just already added this support.

@dlyongemallo
Copy link
Contributor

Hi, @rahulsust,

Thanks for the offer of help.

PR #151 adds support for p but not yet for cp. I have ongoing work to support as much of the OpenQASM 3 standard gate set as is possible or makes sense, but it's not ready yet. If you have an urgent need to support the cp gate, it shouldn't be too hard to add it in an ad hoc manner, using PR #151 as a template.

@rahulsust rahulsust changed the title p and cp gate support for QASMParser cp gate support for QASMParser Sep 8, 2023
@rahulsust
Copy link
Author

Hi, @dlyongemallo,

Thank you for letting me know.

I will start working on it then. If it is okay, can we talk over DM?

@dlyongemallo
Copy link
Contributor

Hi, @rahulsust,

Are you on the ZX-calculus Discord? My user name is the same as on GitHub. You can send me a DM there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants