Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: checks on sendCommand api #816

Merged
merged 6 commits into from
Mar 4, 2021
Merged

fix: checks on sendCommand api #816

merged 6 commits into from
Mar 4, 2021

Conversation

robertsLando
Copy link
Member

No description provided.

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@coveralls
Copy link

coveralls commented Mar 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 621212762

  • 0 of 27 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 18.366%
Changes Missing Coverage Covered Lines Changed/Added Lines %
types/index.d.ts 0 5 0.0%
lib/ZwaveClient.js 0 22 0.0%
Totals Coverage Status
Change from base Build 621043351: -0.02%
Covered Lines: 2022
Relevant Lines: 11290
💛 - Coveralls

@robertsLando robertsLando changed the title fix: sendCommand api checks fix: checks on sendCommand api Mar 4, 2021
AlCalzone
AlCalzone requested changes Mar 4, 2021
View reviewed changes
docs/guide/mqtt.md Outdated Show resolved Hide resolved
lib/ZwaveClient.js Outdated Show resolved Hide resolved
@robertsLando robertsLando merged commit 92d502a into master Mar 4, 2021
@robertsLando robertsLando deleted the fix-sendcommand branch March 4, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone Awaiting requested review from AlCalzone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertsLando @coveralls @AlCalzone