Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read/parse buffers as hex strings #797

Merged
merged 2 commits into from
Mar 2, 2021
Merged

fix: read/parse buffers as hex strings #797

merged 2 commits into from
Mar 2, 2021

Conversation

robertsLando
Copy link
Member

Fixes #782

@coveralls
Copy link

coveralls commented Mar 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 614450498

  • 10 of 53 (18.87%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 18.873%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 18 0.0%
lib/utils.js 10 35 28.57%
Totals Coverage Status
Change from base Build 614317448: 0.08%
Covered Lines: 2022
Relevant Lines: 10993
💛 - Coveralls

AlCalzone
AlCalzone requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also make sure to print buffers in that form, instead of [object ArrayBuffer]

AlCalzone
AlCalzone approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect the zwave-js-server, right?

@robertsLando
Copy link
Member Author

This doesn't affect the zwave-js-server, right?

Nope, they have their own event listeners I only pass the driver instance to them :)

@robertsLando robertsLando changed the title fix: correctly parse buffers fix: read/parse buffers as hex strings Mar 2, 2021
@robertsLando robertsLando merged commit 521d2d2 into master Mar 2, 2021
@robertsLando robertsLando deleted the fix-buffers branch March 2, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[question] Enrollment codes for BeNext/Zipato Keypad
3 participants
@robertsLando @coveralls @AlCalzone