Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to node-zwavejs #6

Merged
merged 47 commits into from
Nov 3, 2020
Merged

feat: move to node-zwavejs #6

merged 47 commits into from
Nov 3, 2020

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Oct 22, 2020

🚀

Copy link
Member

@chrisns chrisns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass at the first few files. Wow you've been busy!

@robertsLando
Copy link
Member Author

There will be many breaking changes but that's also an occasion to make something better. About the docs-related reviews I haven't worked so much on it so there will be many things missing or that need edits

@robertsLando
Copy link
Member Author

robertsLando commented Oct 30, 2020

@chilicheech Unfortunally I don't own many zwave devices to make tests with hass. Could you help me to work on the hass support?

Essentially what is needed is to translate all valueId.index references in Gateway.js to use property and propertyKey. Also some command classes now have two separated valueIds with read only and write only values, one is used to write and one to read, so the state needs to be set to the read only value and the set topic to the write only value. Also some values (like command class color) now are splitted in separeted values (r, g, b) each one has a different propertyKey, for this values we should create another topic with a propertyKey like rgb where the value could be in the format required by hass.

@robertsLando
Copy link
Member Author

I suggest to merge this so at leat there will be also a docker dev tag, I have moved the todos to an issue: #7

@robertsLando
Copy link
Member Author

@chrisns

@robertsLando robertsLando requested a review from chrisns November 2, 2020 13:59
@robertsLando robertsLando changed the title WIP: transition to zwavejs feat: move to node-zwavejs 🚀 Nov 2, 2020
@robertsLando robertsLando changed the title feat: move to node-zwavejs 🚀 feat: move to node-zwavejs Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants