Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown manufacturer #376

Merged
merged 4 commits into from
Jan 29, 2021
Merged

fix: unknown manufacturer #376

merged 4 commits into from
Jan 29, 2021

Conversation

robertsLando
Copy link
Member

Fixes #373
Fixes #347

@coveralls
Copy link

coveralls commented Jan 28, 2021

Pull Request Test Coverage Report for Build 520238894

  • 0 of 29 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 21.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.js 0 29 0.0%
Totals Coverage Status
Change from base Build 520238236: -0.04%
Covered Lines: 2044
Relevant Lines: 9713

💛 - Coveralls

@AlCalzone
Copy link
Member

Like we discussed, I would do it differently. When node is ready, use getDefinedValueIDs() to

  1. detect which values are added and add them
  2. detect which values were removed and remove them
  3. update the others.

@robertsLando
Copy link
Member Author

Like we discussed, I would do it differently. When node is ready, use getDefinedValueIDs() to

Isn't the result of what I did the same?

@AlCalzone
Copy link
Member

AlCalzone commented Jan 28, 2021

The way I'm seeing it, you do 3. but not 1. or 2.

Edit: you also do 1., but with value updated event

@robertsLando
Copy link
Member Author

@AlCalzone When node is ready I get a reference of the existing node values, clear all actual node values , I get all the new defined values, I parse one by one and I check if it was existing (and if it has changed). The removed ones are not there so and the new ones are reported

@AlCalzone
Copy link
Member

Ok then I didn't understand the consequences.

@robertsLando robertsLando merged commit e880354 into master Jan 29, 2021
@robertsLando robertsLando deleted the fix-unknown-manufacturer branch January 29, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants