-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unknown manufacturer #376
Conversation
Pull Request Test Coverage Report for Build 520238894
💛 - Coveralls |
Like we discussed, I would do it differently. When node is ready, use
|
Isn't the result of what I did the same? |
The way I'm seeing it, you do 3. but not 1. or 2. Edit: you also do 1., but with |
@AlCalzone When node is ready I get a reference of the existing node values, clear all actual node values , I get all the new defined values, I parse one by one and I check if it was existing (and if it has changed). The removed ones are not there so and the new ones are reported |
Ok then I didn't understand the consequences. |
Fixes #373
Fixes #347