Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zwave radio configurations #2485

Merged
merged 8 commits into from
Jun 28, 2022
Merged

feat: zwave radio configurations #2485

merged 8 commits into from
Jun 28, 2022

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Jun 24, 2022

Fixes #2319
Schermata da 2022-06-27 15-55-22

@coveralls
Copy link

coveralls commented Jun 24, 2022

Pull Request Test Coverage Report for Build 2576327590

  • 0 of 82 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 24.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ZwaveClient.ts 0 82 0.0%
Totals Coverage Status
Change from base Build 2576320277: -0.1%
Covered Lines: 3682
Relevant Lines: 15626

💛 - Coveralls

@robertsLando robertsLando requested a review from AlCalzone June 24, 2022 11:24
Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to see this landing. We shouldn't just put the user in front of these options though without explanation. This is a very advanced feature that nobody should use without knowing what they are doing.

Some points we need to mention:

  1. Increasing the TX power (normal power level) may be illegal, depending on where the user is located
  2. Increasing the TX power will only make the nodes "hear" the controller better, but not vice versa
  3. The default values for 700 series sticks (at least the ones I've seen) are:
    TX power: 0.0
    measured: +3.3

@robertsLando robertsLando requested a review from AlCalzone June 28, 2022 12:20
@robertsLando robertsLando enabled auto-merge (squash) June 28, 2022 12:20
@robertsLando robertsLando disabled auto-merge June 28, 2022 12:24
@robertsLando robertsLando enabled auto-merge (squash) June 28, 2022 12:24
@robertsLando robertsLando disabled auto-merge June 28, 2022 13:09
@robertsLando robertsLando merged commit 01909ad into master Jun 28, 2022
@robertsLando robertsLando deleted the feat#2319 branch June 28, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Zwave-radio configurations
3 participants