Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inclusion via SmartStart QR code forgets supplied Name #2447

Closed
3 tasks
tommyjlong opened this issue Jun 2, 2022 · 3 comments
Closed
3 tasks

[Bug]: Inclusion via SmartStart QR code forgets supplied Name #2447

tommyjlong opened this issue Jun 2, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@tommyjlong
Copy link

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Manually built (git clone - yarn build - yarn install

Zwavejs2Mqtt version

6.11.0 (tagged branch)

ZwaveJS version

9.3.0

Describe the bug

Inclusion via QR code Smart Start forgets supplied Name.

I don't know if this is the same as #2389 or not, but since Changelog 6.8.0 says the issue was fixed, I wanted to reopen.

To Reproduce

Steps: Action->Mange Nodes-> Inclusion, Next: Enter Name as kitchen_ceiling_lights (but did not enter any Location data), Next: selected "Scan QR Code" where I imported a picture of the QR code, and it returned "Node added to Provisioning List". I did not close this dialog. I went and powered up my node and a popup appeared: "node xxx added with security "S2 Authenticated".

I watched the logs until I saw that the device's interview process was completed. I then closed out the dialogs and checked the control panel to see that the node was added, but there was no location data. I checked the nodes.json and it was not there either.

I was able to manually enter the name afterwards.

Expected behavior

Expected Name to be populated in the node's data after Smart Start based inclusion was successful.

Additional context

No response

@tommyjlong tommyjlong added the bug Something isn't working label Jun 2, 2022
@robertsLando
Copy link
Member

(but did not enter any Location data

Does it work if you provide both location and name?

@tommyjlong
Copy link
Author

I just tried this on a new device. Its a battery device. I repeated the above, but this time included both name and location. After powering up the device, the S2 authentication completed and the device shows up in the control panel. Although the interview process hasn't completed yet, there is still neither name nor location showing up in the control panel..

@robertsLando
Copy link
Member

Found the bug and fixed. Anyway in the meanwhile you can add provisioning entries from provisioning entries tab, in that way it works and it doens't forget node name and location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants