Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add directions to access the UI from within HA #205

Merged
merged 8 commits into from
Jan 11, 2021
Merged

feat: Add directions to access the UI from within HA #205

merged 8 commits into from
Jan 11, 2021

Conversation

blhoward2
Copy link
Collaborator

@blhoward2 blhoward2 commented Jan 11, 2021

This edit adds directions to add the UI to HA using Lovelace, so that the UI is accessible from within HA itself.

Result:

Screen Shot 2021-01-11 at 10 20 29 AM

Adds directions to add the UI to HA using Lovelace.
@blhoward2 blhoward2 changed the title Add directions to access the UI from within HA feat: Add directions to access the UI from within HA Jan 11, 2021
@robertsLando
Copy link
Member

@blhoward2 I would add those instructions under a new section ##

@blhoward2
Copy link
Collaborator Author

Ok

@blhoward2
Copy link
Collaborator Author

blhoward2 commented Jan 11, 2021

@robertsLando How's that?

@robertsLando
Copy link
Member

@blhoward2 LGTM, could you fix lint issues? npm run lint-fix

@blhoward2
Copy link
Collaborator Author

I can tonight. I was doing this through the GitHub website so I need to pull it down to do so.

@robertsLando
Copy link
Member

@zwave-js-bot fix lint

@robertsLando
Copy link
Member

@AlCalzone Arggg

Permission to blhoward2/zwavejs2mqtt.git denied to zwave-js-bot

😢

@robertsLando
Copy link
Member

@zwave-js-bot fix lint

@blhoward2
Copy link
Collaborator Author

@AlCalzone Arggg

Permission to blhoward2/zwavejs2mqtt.git denied to zwave-js-bot

😢

Is there a way for me to give it permission for the future?

@AlCalzone
Copy link
Member

AlCalzone commented Jan 11, 2021

Interesting... Did you check the option "allow maintainers to make changes"? (in the PR)

@zwave-js-bot
Copy link
Collaborator

🔨 I tried my best, but unfortunately some lint errors require manual attention.

@blhoward2
Copy link
Collaborator Author

Think so. I’ve never unchecked it.

@AlCalzone
Copy link
Member

Hmm... think I'll have to investigate. I haven't actually been able to test this on a foreign branch yet.

@robertsLando
Copy link
Member

@AlCalzone I just forgot to add the bot to my repo. Now it has done something but still not working

@AlCalzone
Copy link
Member

AlCalzone commented Jan 11, 2021

Well... it can only fix things that are auto-fixable. Could probably check that and not offer the fix if there isn't anything to do. But since you explicitly requested it, it won't fix :)

@robertsLando
Copy link
Member

Should be fine now. At least I have checked that the bot is working. Thanks @AlCalzone and thanks @blhoward2 for the PR :)

@AlCalzone
Copy link
Member

Want me to enable the fix lint hint comments for this repo too?

@robertsLando
Copy link
Member

@zwave-js-bot fix lint

@robertsLando
Copy link
Member

@AlCalzone Yep would be awesome :)

@AlCalzone
Copy link
Member

Ok, since you're using different linters than me, what's the exact check name and which part of the log indicates that there's a lint error?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 478089113

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 24.76%

Totals Coverage Status
Change from base Build 478065690: 0.0%
Covered Lines: 1938
Relevant Lines: 7996

💛 - Coveralls

@robertsLando robertsLando merged commit 51f715c into zwave-js:master Jan 11, 2021
@blhoward2 blhoward2 deleted the patch-1 branch January 11, 2021 19:27
@blhoward2
Copy link
Collaborator Author

@robertsLando @AlCalzone Can anyone invoke the bot or just you guys? For little things I finding pulling/pushing tedious versus just editing in the website and having it automatically create a PR.

@AlCalzone
Copy link
Member

AlCalzone commented Jan 11, 2021

We both and the respective PR author can do that. So you should be able to.

@blhoward2
Copy link
Collaborator Author

We both and the respective PR author can do that. So you should be able to.

Are there directions on how to use it?

@AlCalzone
Copy link
Member

You comment the following if there is a lint error:
@zwave-js-bot fix lint

A comment explaining that should also appear now (if auto fixing is possible and the script does not fail).

@chilicheech
Copy link
Contributor

OK, so maybe I'm just a noob, but it took me a while to figure out how this works. It might be useful to include a link to https://www.home-assistant.io/lovelace/dashboards-and-views/#panel and describe that you need to create a new Lovelace Dashboard, and then go to its raw editor. Also, the instructions say to use the ip address but make no mention of the protocol, http or https. I was putting in just the ip address and it just kept loading hass in an infinite loop. The instructions should say either:

url: 'http://[PUT IP ADDRESS HERE]:8091/'

or

url: 'PUT THE FULL URL WITH THE PORT HERE'

or even better, with an example:

url: 'http://192.168.1.2:8091'  # replace with the url to your zwavejs2mqtt

@blhoward2
Copy link
Collaborator Author

Ok, I can make those improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants