-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add directions to access the UI from within HA #205
Conversation
Adds directions to add the UI to HA using Lovelace.
@blhoward2 I would add those instructions under a new section |
Ok |
@robertsLando How's that? |
@blhoward2 LGTM, could you fix lint issues? |
I can tonight. I was doing this through the GitHub website so I need to pull it down to do so. |
@zwave-js-bot fix lint |
@AlCalzone Arggg
😢 |
@zwave-js-bot fix lint |
Is there a way for me to give it permission for the future? |
Interesting... Did you check the option "allow maintainers to make changes"? (in the PR) |
🔨 I tried my best, but unfortunately some lint errors require manual attention. |
Think so. I’ve never unchecked it. |
Hmm... think I'll have to investigate. I haven't actually been able to test this on a foreign branch yet. |
@AlCalzone I just forgot to add the bot to my repo. Now it has done something but still not working |
Well... it can only fix things that are auto-fixable. Could probably check that and not offer the fix if there isn't anything to do. But since you explicitly requested it, it won't fix :) |
Should be fine now. At least I have checked that the bot is working. Thanks @AlCalzone and thanks @blhoward2 for the PR :) |
Want me to enable the |
@zwave-js-bot fix lint |
@AlCalzone Yep would be awesome :) |
Ok, since you're using different linters than me, what's the exact check name and which part of the log indicates that there's a lint error? |
Pull Request Test Coverage Report for Build 478089113
💛 - Coveralls |
@robertsLando @AlCalzone Can anyone invoke the bot or just you guys? For little things I finding pulling/pushing tedious versus just editing in the website and having it automatically create a PR. |
We both and the respective PR author can do that. So you should be able to. |
Are there directions on how to use it? |
You comment the following if there is a lint error: A comment explaining that should also appear now (if auto fixing is possible and the script does not fail). |
OK, so maybe I'm just a noob, but it took me a while to figure out how this works. It might be useful to include a link to https://www.home-assistant.io/lovelace/dashboards-and-views/#panel and describe that you need to create a new Lovelace Dashboard, and then go to its raw editor. Also, the instructions say to use the ip address but make no mention of the protocol, http or https. I was putting in just the ip address and it just kept loading hass in an infinite loop. The instructions should say either:
or
or even better, with an example:
|
Ok, I can make those improvements. |
This edit adds directions to add the UI to HA using Lovelace, so that the UI is accessible from within HA itself.
Result: