feat: hass discovery #20

robertsLando · 2020-11-20T11:13:15Z

No description provided.

robertsLando · 2020-11-20T15:24:21Z

Missing:

User tests
Rgb support (Color CC: Add RGBW value ID node-zwave-js#806)
Meter types and sensor types support using translatedValueIds (Better identify valueIds types node-zwave-js#1137)

varet80 · 2020-11-23T18:43:52Z

compiling the container causes the following

- zwavejs2mqtt-5c78f7b7fb-ssspw
+ zwavejs2mqtt-6dcf895c77-qnjpq › z2m
zwavejs2mqtt-6dcf895c77-qnjpq z2m 2020-11-23T18:43:01.366Z z2m:Store scenes.json not found
zwavejs2mqtt-6dcf895c77-qnjpq z2m Error: Cannot find module 'zwave-js/node_modules/@zwave-js/core'
zwavejs2mqtt-6dcf895c77-qnjpq z2m Require stack:
zwavejs2mqtt-6dcf895c77-qnjpq z2m - /usr/src/app/lib/Gateway.js
zwavejs2mqtt-6dcf895c77-qnjpq z2m - /usr/src/app/node_modules/app-root-path/lib/app-root-path.js
zwavejs2mqtt-6dcf895c77-qnjpq z2m - /usr/src/app/node_modules/app-root-path/index.js
zwavejs2mqtt-6dcf895c77-qnjpq z2m - /usr/src/app/bin/www
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:831:15)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Function.Module._load (internal/modules/cjs/loader.js:687:27)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Module.require (internal/modules/cjs/loader.js:903:19)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at require (internal/modules/cjs/helpers.js:74:18)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Object.<anonymous> (/usr/src/app/lib/Gateway.js:13:28)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Module._compile (internal/modules/cjs/loader.js:1015:30)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1035:10)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Module.load (internal/modules/cjs/loader.js:879:32)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Function.Module._load (internal/modules/cjs/loader.js:724:14)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Module.require (internal/modules/cjs/loader.js:903:19)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at require (internal/modules/cjs/helpers.js:74:18)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at require (/usr/src/app/node_modules/app-root-path/lib/app-root-path.js:14:11)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Object.<anonymous> (/usr/src/app/app.js:12:15)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Module._compile (internal/modules/cjs/loader.js:1015:30)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1035:10)
zwavejs2mqtt-6dcf895c77-qnjpq z2m     at Module.load (internal/modules/cjs/loader.js:879:32) {
zwavejs2mqtt-6dcf895c77-qnjpq z2m   code: 'MODULE_NOT_FOUND',
zwavejs2mqtt-6dcf895c77-qnjpq z2m   requireStack: [
zwavejs2mqtt-6dcf895c77-qnjpq z2m     '/usr/src/app/lib/Gateway.js',
zwavejs2mqtt-6dcf895c77-qnjpq z2m     '/usr/src/app/node_modules/app-root-path/lib/app-root-path.js',
zwavejs2mqtt-6dcf895c77-qnjpq z2m     '/usr/src/app/node_modules/app-root-path/index.js',
zwavejs2mqtt-6dcf895c77-qnjpq z2m     '/usr/src/app/bin/www'
zwavejs2mqtt-6dcf895c77-qnjpq z2m   ]
zwavejs2mqtt-6dcf895c77-qnjpq z2m }

hass/devices.js

varet80 · 2020-11-24T07:32:18Z

I am posting separate comments, as it is three separate issues.
My Climate_thermostat is not working as expected here is the discovery and error on the template

zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:27.352Z z2m:App Zwave api call: refreshInfo [ 24 ]
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:27.395Z z2m:Zwave Success zwave api call refreshInfo
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:28.980Z z2m:Zwave Node 64: metadata updated: 49-0-Power
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:28.981Z z2m:Zwave Node 64: value updated: 49-0-Power 82.3 => 88.1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:33.095Z z2m:Zwave Node 64: metadata updated: 49-0-Power
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:33.096Z z2m:Zwave Node 64: value updated: 49-0-Power 88.1 => 79.8
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:33.292Z z2m:Zwave Node 64: metadata updated: 49-0-Power
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:33.293Z z2m:Zwave Node 64: value updated: 49-0-Power 79.8 => 84.1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:40.338Z z2m:Zwave Node 24: value added: 114-0-manufacturerId => 328
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:40.339Z z2m:Zwave Node 24: value added: 114-0-productType => 3
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:40.339Z z2m:Zwave Node 24: value added: 114-0-productId => 1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:41.014Z z2m:Zwave Node 24: value added: 134-0-libraryType => 3
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:41.015Z z2m:Zwave Node 24: value added: 134-0-protocolVersion => 4.61
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:41.015Z z2m:Zwave Node 24: value added: 134-0-firmwareVersions => [ '0.16' ]
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:41.979Z z2m:Zwave Node 64: metadata updated: 49-0-Power
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:41.980Z z2m:Zwave Node 64: value updated: 49-0-Power 84.1 => 79.8
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:42.978Z z2m:Zwave Node 64: metadata updated: 49-0-Power
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:42.979Z z2m:Zwave Node 64: value updated: 49-0-Power 79.8 => 85.8
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.478Z z2m:Zwave Node 24: value added: 94-0-zwavePlusVersion => 1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.479Z z2m:Zwave Node 24: value added: 94-0-nodeType => 0
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.479Z z2m:Zwave Node 24: value added: 94-0-roleType => 7
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.479Z z2m:Zwave Node 24: value added: 94-0-installerIcon => 4608
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.479Z z2m:Zwave Node 24: value added: 94-0-userIcon => 4608
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.686Z z2m:Zwave Node 24: value added: 128-0-level => 95
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.686Z z2m:Zwave Node 24: value added: 128-0-isLow => false
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:44.896Z z2m:Zwave Node 24: metadata updated: 64-0-mode
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:45.116Z z2m:Zwave Node 24: value added: 64-0-mode => 1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:45.541Z z2m:Zwave Node 24: metadata updated: 67-0-setpoint-1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:45.759Z z2m:Zwave Node 24: value added: 67-0-setpoint-1 => 19
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:45.968Z z2m:Zwave Node 24: metadata updated: 67-0-setpoint-11
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:46.177Z z2m:Zwave Node 24: value added: 67-0-setpoint-11 => 18
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:46.387Z z2m:Zwave Node 24: value added: 117-0-local => 0
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.017Z z2m:Zwave Node 24: metadata updated: 49-0-Air temperature
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.017Z z2m:Zwave Node 24: value added: 49-0-Air temperature => 18.4
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.034Z z2m:Zwave Node 24: metadata updated: 38-0-Up
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.035Z z2m:Zwave Node 24: metadata updated: 38-0-Down
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.226Z z2m:Zwave Node 24: value added: 38-0-targetValue => undefined
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.227Z z2m:Zwave Node 24: value added: 38-0-currentValue => 13
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.250Z z2m:Zwave Node 24: metadata updated: 112-0-1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.251Z z2m:Zwave Node 24: metadata updated: 112-0-2
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.251Z z2m:Zwave Node 24: metadata updated: 112-0-3
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.251Z z2m:Zwave Node 24: metadata updated: 112-0-4
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.252Z z2m:Zwave Node 24: metadata updated: 112-0-5
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.252Z z2m:Zwave Node 24: metadata updated: 112-0-6
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.252Z z2m:Zwave Node 24: metadata updated: 112-0-7
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.252Z z2m:Zwave Node 24: metadata updated: 112-0-8
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.443Z z2m:Zwave Node 24: value added: 112-0-1 => 0
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.660Z z2m:Zwave Node 24: value added: 112-0-2 => 0
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:47.882Z z2m:Zwave Node 24: value added: 112-0-3 => 1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:48.101Z z2m:Zwave Node 24: value added: 112-0-4 => 1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:48.323Z z2m:Zwave Node 24: value added: 112-0-5 => 2
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:48.542Z z2m:Zwave Node 24: value added: 112-0-6 => 1
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:48.762Z z2m:Zwave Node 24: value added: 112-0-7 => 2
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:48.979Z z2m:Zwave Node 24: value added: 112-0-8 => 0
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:50.541Z z2m:Zwave Node 24: metadata updated: 113-0-Power Management-Battery maintenance status
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:50.747Z z2m:Zwave Node 24: metadata updated: 113-0-System-Hardware status
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:50.784Z z2m:Zwave Node 24: interview completed, all values are updated
zwavejs2mqtt-bd558b8f-m7l2b z2m 2020-11-24T07:30:50.785Z z2m:Gateway Error while discovering device climate_thermostat of node 24: Cannot read property 'id' of undefined

this is a SPIRITz all of these do behave the same.

robertsLando · 2020-11-24T08:04:13Z

compiling the container causes the following

Did you fixed this? I think it's a user error

varet80 · 2020-11-24T08:07:23Z

I compiled on my WSL2 and my mac + an extra machine with your instructions I still get the same module error!

from my wsl2 using ubuntu 20.04


> [email protected] start /home/billias/ongit/zwavejs2mqtt
> node bin/www

  z2m:Store settings.json not found +0ms
  z2m:Store scenes.json not found +3ms
  z2m:Store nodes.json not found +0ms
{ Error: Cannot find module 'zwave-js/node_modules/@zwave-js/core'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/billias/ongit/zwavejs2mqtt/lib/Gateway.js:13:28)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at require (/home/billias/ongit/zwavejs2mqtt/node_modules/app-root-path/lib/app-root-path.js:14:11)
    at Object.<anonymous> (/home/billias/ongit/zwavejs2mqtt/app.js:12:15)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10) code: 'MODULE_NOT_FOUND' }
❯ git pull
remote: Enumerating objects: 9, done.
remote: Counting objects: 100% (9/9), done.
remote: Total 9 (delta 8), reused 9 (delta 8), pack-reused 0
Unpacking objects: 100% (9/9), 1.25 KiB | 75.00 KiB/s, done.
From github.com:zwave-js/zwavejs2mqtt
   17280f5..af55b9b  master     -> origin/master
Already up to date.

╭─░▒▓  ~/ongit/zwavejs2mqtt    feat#hassDiscovery !8 ───

the !8 is after compilation, new files

robertsLando · 2020-11-24T08:13:14Z

@AlCalzone where could cannot find module @zwave-js/core' error come from?

robertsLando · 2020-11-24T08:13:48Z

@billiaz What device is this? I mean the thermostat you are using

robertsLando · 2020-11-24T08:23:01Z

@billiaz Pull latest and retry :)

coveralls · 2020-11-24T13:56:24Z

Pull Request Test Coverage Report for Build 391618089

188 of 486 (38.68%) changed or added relevant lines in 7 files are covered.
29 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.5%) to 28.785%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app.js	0	7	0.0%
lib/ZwaveClient.js	0	31	0.0%
lib/Gateway.js	52	312	16.67%

Files with Coverage Reduction	New Missed Lines	%
lib/utils.js	1	85.19%
lib/Gateway.js	28	21.52%

Totals
Change from base Build 387238528:	0.5%
Covered Lines:	1827
Relevant Lines:	6474

💛 - Coveralls

robertsLando · 2020-11-24T14:56:10Z

@chrisns Give this a look when you have time please :) expecially on README

README.md

lib/Gateway.js

robertsLando · 2020-11-30T12:49:12Z

@billiaz Is there something else that is failing?

robertsLando added 6 commits November 20, 2020 12:12

feat: bind target values to current

54afd1e

feat(wip): hass discovery

1fc0cd6

fix: better discovery support

5fcb0d3

fix: hass socket apis

320ea8c

fix: alarmType and meterType mapping

7ac9560

fix: use commandClasses instead of hardCoded numbers

ab85eca

robertsLando added 11 commits November 20, 2020 16:45

refactor: better docs on methods

63ba463

fix: converted some values in hass devices.js

8680cc1

fix: converted some more values in devices.js

fd3a1fc

feat: skip discovety flag

54e6d37

fix: lint issues

36f757a

fix: ignore discovery

bdf5d48

fix: converted some more valueIds of devices.json

e5234f2

fix: lint issues

e35dc78

fix: push target value in values

08bf31c

fix: mode_map and fan _mode_map

ec99ca8

fix: allow empty json device

08f4c77

fix: added ccSpecific to value meta

0573aa4

varet80 reviewed Nov 24, 2020

View reviewed changes

hass/devices.js Outdated Show resolved Hide resolved

robertsLando added 3 commits November 24, 2020 09:15

fix: setpoints valueIds

5ed57f3

fix: commandclasses import

335426b

fix: set defaiult endpoint to 0

c2f87b5

robertsLando added 5 commits November 24, 2020 14:04

fix: mode_map template creation

85c03ae

fix: added brackets to keys

5856e9c

fix: added comments

b6b046a

fix: getMappedValuesTemplate check type of value

e5aaada

fix: lint errors

f872e1f

robertsLando added 3 commits November 24, 2020 15:15

docs: fixed hass docs

887ae73

docs: migration and why zwavejs

208f58b

docs: bitmask and color values

0bb517c

robertsLando requested a review from chrisns November 24, 2020 14:55

robertsLando added 2 commits November 24, 2020 17:05

Merge branch 'master' into feat#hassDiscovery

8c05460

fix: lint issues

52cbcdb

chrisns requested changes Nov 25, 2020

View reviewed changes

robertsLando added 6 commits November 25, 2020 14:03

docs: fix for review

709fb9c

fix: typo

e39b6a8

fix: lint on readme

0ab98e7

docs: fix

69b7a46

Merge branch 'master' into feat#hassDiscovery

c23d27d

docs: added some points to why zwavejs section

f639533

robertsLando requested a review from chrisns November 25, 2020 13:47

robertsLando and others added 5 commits November 27, 2020 12:08

Merge branch 'master' into feat#hassDiscovery

5442408

fix: payload parse of modes when discovery is enabled

ac43537

Merge branch 'master' into feat#hassDiscovery

815b497

fix: missing ccSpecific values (#35)

ac4ed9a

fix: binary sensors, units and undefined labels (#36)

23f8cb3

fix: lint issues

6c1c4ad

robertsLando merged commit 3794e34 into master Nov 30, 2020

robertsLando deleted the feat#hassDiscovery branch November 30, 2020 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: hass discovery #20

feat: hass discovery #20

robertsLando commented Nov 20, 2020

robertsLando commented Nov 20, 2020 •

edited

Loading

varet80 commented Nov 23, 2020 •

edited

Loading

varet80 commented Nov 24, 2020

robertsLando commented Nov 24, 2020

varet80 commented Nov 24, 2020

robertsLando commented Nov 24, 2020 •

edited

Loading

robertsLando commented Nov 24, 2020

robertsLando commented Nov 24, 2020

coveralls commented Nov 24, 2020 •

edited

Loading

robertsLando commented Nov 24, 2020

robertsLando commented Nov 30, 2020

feat: hass discovery #20

feat: hass discovery #20

Conversation

robertsLando commented Nov 20, 2020

robertsLando commented Nov 20, 2020 • edited Loading

varet80 commented Nov 23, 2020 • edited Loading

varet80 commented Nov 24, 2020

robertsLando commented Nov 24, 2020

varet80 commented Nov 24, 2020

robertsLando commented Nov 24, 2020 • edited Loading

robertsLando commented Nov 24, 2020

robertsLando commented Nov 24, 2020

coveralls commented Nov 24, 2020 • edited Loading

Pull Request Test Coverage Report for Build 391618089

💛 - Coveralls

robertsLando commented Nov 24, 2020

robertsLando commented Nov 30, 2020

robertsLando commented Nov 20, 2020 •

edited

Loading

varet80 commented Nov 23, 2020 •

edited

Loading

robertsLando commented Nov 24, 2020 •

edited

Loading

coveralls commented Nov 24, 2020 •

edited

Loading