-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: icons are no longer displayed after css-loader major upgrade #1729
Conversation
Pull Request Test Coverage Report for Build 1270762142
💛 - Coveralls |
You also need to fix your commit message. |
@firstof9, I've seen the complaint about "Semantic PR title / commit message" and then already changed the title of the PR to comply to conventional commits. |
Nope your commit message also needs to follow suit. |
5c8799b
to
5ef6aa8
Compare
@firstof9, done. |
Cheers! |
@ahochsteger you can also try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will try to fix the breaking changes once I come back. Thanks!
@blhoward2, thanks, I was not aware, that for single-commit PRs the real commit message must be changed. I thought the PR title can be used as well for the merge commit. |
I'm not sure there is a right way. I've seen people force push. I've seen others push empty commits. I'm honestly not the expert because rarely do I do anything in one commit. 😬 We frequently use the bot to fix it for submitters. |
This reverts commit 7063434.
Fixes #1728