Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MQTT_NAME env var #1481

Merged
merged 8 commits into from
Jul 30, 2021
Merged

Conversation

mannerydhe
Copy link
Contributor

I added the option to configure the mqtt name using an env variable.

I needed this in order to manage several pods in a kubernetes cluster.

@robertsLando robertsLando changed the title Added env variable for mqtt name. feat: MQTT_NAME env variable for mqtt name. Jul 28, 2021
@robertsLando
Copy link
Member

@mannerydhe Could you add the env var to docs please? There is a doc dedicated to env vars :)

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧

I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@mannerydhe
Copy link
Contributor Author

@mannerydhe Could you add the env var to docs please? There is a doc dedicated to env vars :)

Done!

@robertsLando robertsLando changed the title feat: MQTT_NAME env variable for mqtt name. feat: add MQTT_NAME env var Jul 30, 2021
robertsLando
robertsLando previously approved these changes Jul 30, 2021
@robertsLando robertsLando enabled auto-merge (squash) July 30, 2021 06:27
@zwave-js zwave-js deleted a comment from zwave-js-bot Jul 30, 2021
@robertsLando
Copy link
Member

@zwave-js-bot fix lint

@zwave-js-bot
Copy link
Collaborator

🐌 Please wait for the lint check to complete, then try again.

@zwave-js zwave-js deleted a comment from zwave-js-bot Jul 30, 2021
@AlCalzone
Copy link
Member

@zwave-js-bot fix lint

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1081577648

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 30.366%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/MqttClient.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 1081482739: -0.005%
Covered Lines: 3612
Relevant Lines: 12500

💛 - Coveralls

@robertsLando robertsLando merged commit 5097a26 into zwave-js:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants