-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MQTT_NAME
env var
#1481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
changed the title
Added env variable for mqtt name.
feat: MQTT_NAME env variable for mqtt name.
Jul 28, 2021
@mannerydhe Could you add the env var to docs please? There is a doc dedicated to env vars :) |
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
Done! |
robertsLando
changed the title
feat: MQTT_NAME env variable for mqtt name.
feat: add Jul 30, 2021
MQTT_NAME
env var
robertsLando
previously approved these changes
Jul 30, 2021
@zwave-js-bot fix lint |
🐌 Please wait for the lint check to complete, then try again. |
@zwave-js-bot fix lint |
Pull Request Test Coverage Report for Build 1081577648
💛 - Coveralls |
robertsLando
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the option to configure the mqtt name using an env variable.
I needed this in order to manage several pods in a kubernetes cluster.