Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the GE/Jasco 14314 to use the fan dimmer hass discovery #1476

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

ammmze
Copy link
Contributor

@ammmze ammmze commented Jul 25, 2021

I've got a couple of the GE 14314 with the older firmware (i.e. the 12600 product id). But figured while I was at it I should also add 12850 which should be newer variants per the zwave alliance data. You will see there are 3 variants registered as 14314. 2 of which share the 12600 (i.e. 0x3138 hex encoded) product id and 1 has 12850 (i.e. 0x3232 hex encoded).

@robertsLando robertsLando enabled auto-merge (squash) July 26, 2021 07:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1063952365

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-10.9%) to 19.484%

Totals Coverage Status
Change from base Build 1056447885: -10.9%
Covered Lines: 3612
Relevant Lines: 19666

💛 - Coveralls

@robertsLando robertsLando merged commit 44ba47f into zwave-js:master Jul 26, 2021
@ammmze ammmze deleted the ge-14314-fan-control branch July 26, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants