Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Heal status for a node not updated in UI when healing single node #1375

Closed
4 of 7 tasks
jmgiaever opened this issue Jun 24, 2021 · 2 comments · Fixed by #1377
Closed
4 of 7 tasks

[bug] Heal status for a node not updated in UI when healing single node #1375

jmgiaever opened this issue Jun 24, 2021 · 2 comments · Fixed by #1377
Assignees
Labels
bug Something isn't working

Comments

@jmgiaever
Copy link
Contributor

jmgiaever commented Jun 24, 2021

Version

Checklist:

  • I am not using HomeAssistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog problem was not mentioned there.

Build/Run method

  • Docker
  • PKG
  • Snap package
  • Manually built (git clone - yarn install - yarn run build )

zwavejs2mqtt: 5.0.4.ebfd0b3
zwave-js: 7.7.5

Describe the bug

The «heal-colum» in the UI doesn't update if you heal a single node. Only when you heal the whole network.

To Reproduce

Steps to reproduce the behavior:

  1. Go to control paneø
  2. Click on a node and then advanced
  3. Choose heal node
  4. The heal status is the UI will not update.

Expected behavior

The status should update also on single node heals. E.g if you heal the whole network and some nodes fails, it should be possible to heal a single node and then get the process/status for the node, like for when healing the whole network.

@jmgiaever jmgiaever added the bug Something isn't working label Jun 24, 2021
@jmgiaever jmgiaever changed the title [bug] Heal status for a node not updated when healing single node [bug] Heal status for a node not updated in UI when healing single node Jun 24, 2021
@robertsLando
Copy link
Member

@AlCalzone Maybe you should emit the update in progress event even for a single heal?

@AlCalzone
Copy link
Member

I don't see the need for that additional complexity. If you heal a single node, there's one of 3 possible states:

  1. in progress (which is after you started it)
  2. done with success (the promise resolved to true)
  3. done with failure (the promise resolved to false)

Should be easy enough to handle in the UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants