Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: place plugins route before history middleware #1339

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Jun 14, 2021

cc @kvaster. I also tried to place history middleware right before error handlers but that's not working. I have placed the pluginsRouter before the history one as you suggested

@coveralls
Copy link

Pull Request Test Coverage Report for Build 935799629

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+10.9%) to 30.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 935327772: 10.9%
Covered Lines: 3571
Relevant Lines: 12287

💛 - Coveralls

@robertsLando robertsLando merged commit c223331 into master Jun 14, 2021
@robertsLando robertsLando deleted the fix-plugins-apis branch June 14, 2021 12:51
@kvaster
Copy link
Contributor

kvaster commented Jun 14, 2021

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants