Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hass): sending true to MultilevelSwitchCC doesn't restore old level #1134

Merged
merged 1 commit into from
May 4, 2021
Merged

fix(hass): sending true to MultilevelSwitchCC doesn't restore old level #1134

merged 1 commit into from
May 4, 2021

Conversation

sovapatr
Copy link
Contributor

@sovapatr sovapatr commented May 4, 2021

Fixes #1132

robertsLando
robertsLando approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando changed the title fix: Change payload for boolean true to be 0xff instead of max value. fix(hass): sending true to MultilevelSwitchCC doesn't restore old level May 4, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 810178931

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 17.732%
Totals Coverage Status
Change from base Build 806601496: 0.0%
Covered Lines: 2031
Relevant Lines: 11749
💛 - Coveralls

@robertsLando robertsLando merged commit 13afb0a into zwave-js:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Sending ON to Multilevel Switch sets value to max instead of Previous State
3 participants
@sovapatr @coveralls @robertsLando