Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent 404 errors in store when using nginx #1060

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Apr 15, 2021

@coveralls
Copy link

Pull Request Test Coverage Report for Build 751037167

  • 0 of 43 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 17.971%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/apis/ConfigApis.js 0 9 0.0%
app.js 0 34 0.0%
Totals Coverage Status
Change from base Build 748559265: 0.01%
Covered Lines: 2030
Relevant Lines: 11585

💛 - Coveralls

@frenck
Copy link

frenck commented Apr 15, 2021

will set up a local test with this branch 👍 (right away)

@frenck
Copy link

frenck commented Apr 15, 2021

Yep, works, instantly 🎉 👍 ❤️

@robertsLando robertsLando merged commit b8dd575 into master Apr 15, 2021
@robertsLando robertsLando deleted the fix-store branch April 15, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Request failed with status code 404 when opening files from Control panel
3 participants