Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Danfoss LC13 not discovering all values #607

Closed
Wojcioo opened this issue Feb 17, 2021 · 25 comments · Fixed by #692
Closed

[question] Danfoss LC13 not discovering all values #607

Wojcioo opened this issue Feb 17, 2021 · 25 comments · Fixed by #692
Assignees
Labels
question Further information is requested

Comments

@Wojcioo
Copy link

Wojcioo commented Feb 17, 2021

Hello
I have 3 different Danfoss Living Connect Z Thermostat. For two of them all values are identified properly and I can see them in the ZWaveJS2MQTT Control Panel. This are:
climate_thermostat
sensor_battery_level
binary_sensor_battery_islow

But for one I can only:
sensor_battery_level
binary_sensor_battery_islow

I've installed this on RPI3 using this instruction: https://flemmingss.com/how-to-set-up-zwavejs2mqtt-on-a-raspberry-pi-and-integrate-it-with-home-assistant/
My question is, how can I get the other values to show up as home assistant devices?
Cheers,

image
image

@Wojcioo Wojcioo added the question Further information is requested label Feb 17, 2021
@robertsLando
Copy link
Member

@Wojcioo Logs please

@Wojcioo
Copy link
Author

Wojcioo commented Feb 17, 2021

@robertsLando
Copy link
Member

2021-02-17 17:09:08.453 INFO ZWAVE: Node 2 is now awake
2021-02-17 17:09:08.455 WARN GATEWAY: Unable to discover climate device, there is no valid temperature valueId

Do you have any air temperature value id in your values?

@robertsLando
Copy link
Member

cc @billiaz

@Wojcioo
Copy link
Author

Wojcioo commented Feb 18, 2021

2021-02-17 17:09:08.453 INFO ZWAVE: Node 2 is now awake
2021-02-17 17:09:08.455 WARN GATEWAY: Unable to discover climate device, there is no valid temperature valueId

Do you have any air temperature value id in your values?

Do you mean in this place?
image
I've got 21.

@robertsLando
Copy link
Member

Nope, it's a mulilevel sensor CC, do you have any sensor multilevel defined? Try to send me a node export

@varet80
Copy link
Collaborator

varet80 commented Feb 18, 2021

Danfoss has no feedback of temp.
I will test my lc13 i have and try to make a patch

@robertsLando
Copy link
Member

Lol so we need to patch the discover climate funcion to work even without a temp

@Wojcioo
Copy link
Author

Wojcioo commented Feb 18, 2021

Nope, it's a mulilevel sensor CC, do you have any sensor multilevel defined? Try to send me a node export

node_2.txt

@robertsLando
Copy link
Member

Yep the temperature is missing, that's why the climate device isn't discovered. As I said this requires a patch in Gateway discoverClimate function to allow create climate devices without a temperature

@varet80
Copy link
Collaborator

varet80 commented Feb 19, 2021

I will look into this, probably tomorrow After I fiind one LC13/12 which has the same CC/values

@varet80
Copy link
Collaborator

varet80 commented Feb 19, 2021

@Wojcioo can you also export node 3? It will help me understand why one works, when the other just not

@Wojcioo
Copy link
Author

Wojcioo commented Feb 19, 2021

I will look into this, probably tomorrow After I fiind one LC13/12 which has the same CC/values

Thank you :)

node_11.txt
node_3.txt

@varet80
Copy link
Collaborator

varet80 commented Feb 22, 2021

I see, the Air temp is hardcoded to Climate control, which makes no sense to me

can you delete from device 11 the discovery payload and add a new one as the one i paste here?

{
            "type": "climate",
            "object_id": "thermostat_test",
            "values": [
                "67-0-setpoint-1"
            ],
            "setpoint_topic": {
                "1": "67-0-setpoint-1"
            },
            "default_setpoint": "67-0-setpoint-1",
            "discovery_payload": {
                "min_temp": 4,
                "max_temp": 28,
                "mode_command_topic": false,
                "temp_step": 0.5,
                "temperature_state_template": "{{ value_json.value }}",
                "temperature_command_topic": "zwave2mqtt/danfoss-alek/67/0/setpoint/1/set",
                "temperature_state_topic": "zwave2mqtt/danfoss-alek/67/0/setpoint/1",
                "device": {
                    "identifiers": [
                        "zwavejs2mqtt_0xe6dcf749_node11"
                    ],
                    "manufacturer": "Danfoss",
                    "model": "Living Connect Z Thermostat (LC-13)",
                    "name": "danfoss-alek",
                    "sw_version": "1.1"
                },
                "name": "danfoss-alek_thermostat_test",
                "unique_id": "zwavejs2mqtt_0xe6dcf749_Node11_thermostat_test"
            },
            "discoveryTopic": "climate/danfoss-alek/thermostat_test/config",
            "persistent": false,
            "ignoreDiscovery": false,
            "id": "climate_thermostat_test"
        }

this should create a thermostat_test !!!! if this works, I will need to look into automating this

@Wojcioo
Copy link
Author

Wojcioo commented Feb 22, 2021

this should create a thermostat_test !!!! if this works...

this works with 11

image

but 2 was working wrong, and you would like to test this on 11 to improve 2?

@varet80
Copy link
Collaborator

varet80 commented Feb 22, 2021

@Wojcioo knowing how HASS works! i believe node 11 will work until for some reason is unregistered from HASS
they have the same payload.
is thei thermostat_test showing in HASS?

if so I will send you also a test for node 3! and then we will delete them and try a patch.

@Wojcioo
Copy link
Author

Wojcioo commented Feb 22, 2021

is thei thermostat_test showing in HASS?

Yes, it is.
image

if so I will send you also a test for node 3! and then we will delete them and try a patch.

Thank you.

@varet80
Copy link
Collaborator

varet80 commented Feb 22, 2021

seems nice! I think it is easy to fix in short term. Do you know how to run/build from branch? @Wojcioo
do you use docker?

@Wojcioo
Copy link
Author

Wojcioo commented Feb 22, 2021

I'm using docker.....

@varet80
Copy link
Collaborator

varet80 commented Feb 22, 2021

@Wojcioo I will try to make a docker image for testing! but It will take a bit as I need to test the source code works myself, to submit in one go.

@varet80
Copy link
Collaborator

varet80 commented Feb 22, 2021

@Wojcioo can you try container varet/zj2m:fix-607

and give me feedback

@Wojcioo
Copy link
Author

Wojcioo commented Feb 23, 2021

and give me feedback
@billiaz it looks ok.
image
image

@varet80
Copy link
Collaborator

varet80 commented Feb 23, 2021

@robertsLando we need to wait a bit for this
On Eurotronic, modes are not properly populated, when I remove the hardcoded device! I will also fix that! and then we can merge!

Testing with

  • Danfoss
  • Eurotronic

This was never tested as there was a hass/device.js declaration! which I try to also cleanup :)

@Wojcioo
Copy link
Author

Wojcioo commented Mar 4, 2021

I've uploaded new version, and this node is correct discovered both in zwavejs2mqtt and in Home Assistant, but in HA in logs there is an error

Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:489
Integration: Sensor (documentation, issues)
First occurred: 12:49:31 (3 occurrences)
Last logged: 16:22:09

Platform mqtt does not generate unique IDs. ID zwavejs2mqtt_0xe6dcf749_2-128-0-level already exists - ignoring sensor.sypialnia_danfoss_sypialnia_battery_level

I can't also find battery level in mqtt integration / devices.

image

I've checked all entities and I can't find more then one NodeID: 2. Where should I look for the error?

@varet80
Copy link
Collaborator

varet80 commented Mar 4, 2021

LC 13 has one battery level. therefore what you see is right.
the ID is uniquie.

can you please export the node you receie this message from?
also would be nice if this issue was separate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants