Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support otw update #2886

Merged
merged 22 commits into from
Jan 23, 2023
Merged

feat: support otw update #2886

merged 22 commits into from
Jan 23, 2023

Conversation

robertsLando
Copy link
Member

No description provided.

@robertsLando
Copy link
Member Author

cc @AlCalzone

@coveralls
Copy link

coveralls commented Jan 16, 2023

Pull Request Test Coverage Report for Build 3939487789

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 172 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 24.086%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stores/base.js 0 11 0.0%
lib/ZwaveClient.ts 0 161 0.0%
Totals Coverage Status
Change from base Build 3938205728: -0.2%
Covered Lines: 3784
Relevant Lines: 16597

💛 - Coveralls

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing a BIG FAT WARNING here:
grafik

If a user uploads the wrong file, the controller can be bricked. 700 series may be recoverable via the bootloader, see also https://zwave-js.github.io/node-zwave-js/#/api/driver?id=driver-events.
500 series is likely gone if the wrong file gets uploaded.

Also it would be good if the bootloader/fallback mode of the controller could be exposed - maybe in a separate PR though. See https://zwave-js.github.io/node-zwave-js/#/api/driver?id=zwaveoptions -> allowBootloaderOnly description.

@AlCalzone
Copy link
Member

AlCalzone commented Jan 16, 2023

Testing result:
I didn't see any progress and the update seems to have been done with an empty file, so nothing actually got uploaded.

src/views/ControlPanel.vue Outdated Show resolved Hide resolved
@robertsLando robertsLando merged commit 999d863 into master Jan 23, 2023
@robertsLando robertsLando deleted the feat-otw-update branch January 23, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants