Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): use zwave-js's new pack utility, optimize layers, copy snippets #2688

Merged
merged 5 commits into from
Sep 27, 2022

Conversation

AlCalzone
Copy link
Member

This PR does a few things:

  1. make Dockerfile.contrib compatible with zwave-js 10 and replace the hacky solution for packing the local build with a better one
  2. reduce the number of layers by grouping RUN commands
  3. fix a crash caused by a missing snippets folder

@coveralls
Copy link

coveralls commented Sep 27, 2022

Pull Request Test Coverage Report for Build 3135742557

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 24.632%

Totals Coverage Status
Change from base Build 3135716229: 0.0%
Covered Lines: 3730
Relevant Lines: 15986

💛 - Coveralls

robertsLando
robertsLando previously approved these changes Sep 27, 2022
# Update the version info to match the branch built
RUN yarn workspaces foreach version $(echo $(yarn node -p 'require("semver").inc(require("zwave-js/package.json").version, "prerelease")+".dev"')-$(git rev-parse --short HEAD)) --deferred && yarn version apply --all

RUN yarn workspaces foreach pack
# Pack the repo into tarballs that reference each other
RUN yarn monopack --target $(pwd) --no-version --absolute
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who has created this awesome package? 😜

@robertsLando robertsLando enabled auto-merge (squash) September 27, 2022 12:49
@robertsLando robertsLando enabled auto-merge (squash) September 27, 2022 12:50
@robertsLando robertsLando merged commit 281e9c0 into master Sep 27, 2022
@robertsLando robertsLando deleted the fix-pack branch September 27, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants