Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Try to look up manufacturer name if device doesn't have a config file #1571

Closed
AlCalzone opened this issue Aug 16, 2021 · 2 comments
Closed

[feat] Try to look up manufacturer name if device doesn't have a config file #1571

AlCalzone opened this issue Aug 16, 2021 · 2 comments
Assignees
@robertsLando
Labels
enhancement New feature or request

Comments

@AlCalzone
Copy link
Member

Instead of displaying "unknown manufacturer 0x1234", z2m should use this method to try and look up the manufacturer name first:
https://zwave-js.github.io/node-zwave-js/#/api/config-manager?id=lookupmanufacturer
which is exposed via the driver's configManager instance.

If that doesn't return anything, falling back to "unknown manufacturer" is fine IMO.
@AlCalzone AlCalzone added the enhancement New feature or request label Aug 16, 2021
@AlCalzone
Copy link
Member Author

See commit comment. I don't think your fix does what it's supposed to.

@AlCalzone AlCalzone reopened this Aug 24, 2021
@robertsLando
Copy link
Member

Fixed now, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertsLando robertsLando

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robertsLando @AlCalzone