Skip to content
This repository has been archived by the owner on Jun 2, 2018. It is now read-only.

Support for NSMapTable #271

Closed
wants to merge 1 commit into from
Closed

Conversation

hfossli
Copy link
Contributor

@hfossli hfossli commented Oct 21, 2014

Pretty much the same as NSDictionary categories.

@zwaldowski
Copy link
Collaborator

Thanks for the contribution! -match: should compose using -each: and -apply: shouldn't be implemented since we can't concurrently enumerate a map table. All category methods should be prefixed using bk_ and it is not mergable with master. If you would rather not make those changes, we could ourselves in short order.

@hfossli
Copy link
Contributor Author

hfossli commented Oct 21, 2014

Ah. Now I get why this has conflicts with master. My fork is based on June 2013.. Haha. That's why I didn't see any prefixes in the NSDictionary+BlocksKit implementation which again lead me to think some magic added those prefixes..

I will totally create a new pull request tomorrow.

@hfossli hfossli closed this Oct 21, 2014
@hfossli hfossli deleted the nsmaptable branch October 21, 2014 20:12
@hfossli
Copy link
Contributor Author

hfossli commented Oct 22, 2014

Okay, a new pull request is now open at #272. I removed -apply: as you suggested. -match: should IMO not use -each: because stopping the iteration is IMO important.

@zwaldowski
Copy link
Collaborator

Right, silly me. Wasn't thinking. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants