Skip to content
This repository has been archived by the owner on Jun 2, 2018. It is now read-only.

BKTimerBlock should get the timer object when using NSTimer #163

Closed
shaioz opened this issue Aug 5, 2013 · 3 comments
Closed

BKTimerBlock should get the timer object when using NSTimer #163

shaioz opened this issue Aug 5, 2013 · 3 comments

Comments

@shaioz
Copy link
Contributor

shaioz commented Aug 5, 2013

Why shouldn't I be able to do this:

[NSTimer timerWithTimeInterval:1 block:^(NSTimeInterval time, NSTimer *timer) {
if (YES) {
[timer invalidate];
}
} repeats:YES];

?

@shaioz
Copy link
Contributor Author

shaioz commented Aug 9, 2013

All right I want to fix this myself and request a pull but I've got a question.
BKTimerBlock currently receives an NSTimerInterval as parameter - will it be OK to break its declaration and make it receive an NSTimer instance instead? It will break existing usages...
The interval can be accessed using the NSTimer tough.

@a2
Copy link
Collaborator

a2 commented Aug 9, 2013

Sorry for the delay. This will be updated in BlocksKit 2.0.

@shaioz
Copy link
Contributor Author

shaioz commented Aug 9, 2013

All right.
I still think I'll fork it like I said and request a pull - feel free to pull if you want :)

@a2 a2 closed this as completed Sep 3, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants