Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagecontrol overflow #26

Closed
kafejo opened this issue Apr 5, 2016 · 6 comments
Closed

Pagecontrol overflow #26

kafejo opened this issue Apr 5, 2016 · 6 comments
Labels

Comments

@kafejo
Copy link
Contributor

kafejo commented Apr 5, 2016

If there are many images, the pagecontrol oveflows it's superview.

screenshot 2016-04-05 09 03 25

Any idea how to solve that? (I mean UI solution)

@zvonicek
Copy link
Owner

zvonicek commented Apr 5, 2016

Well, this is certainly an edge case and I'm not sure what the best solution is. But it should probably involve custom page control component since the default one doesn't have such handling. One idea of such component is described here http://stackoverflow.com/a/4749359/1190784

A quick fix here is to simply hide page control in such cases, but that's probably not what you're looking for.

@El-Fitz
Copy link
Contributor

El-Fitz commented Dec 4, 2016

Maybe replacing the PageControl with some sort of label displaying the page number / total number of pages ? (when there's too many items, or just as an alternative)
I'll try looking into it, if I may, whenI get some stuff off my plate

@thihaaung6245
Copy link

thihaaung6245 commented Mar 19, 2017

Working on it for displaying captions of pagecontrol (current/total)
+1

@lukeleleh
Copy link

Any update for this? 😄

@scottcc
Copy link

scottcc commented Jun 20, 2017

+1 bump!

@zvonicek
Copy link
Owner

It's been a long time! But I can finally close this issue 🎉

I've implemented a PageIndicatorView protocol in #251 that anyone can adopt to use their own page indicator. Also a numeric page indicator, LabelPageIndicator, showing just page numbers, is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants