build(deps): bump serve-static from 1.15.0 to 1.16.2 #5887
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [serve-static](https://github.com/expressjs/serve-static) from 1.15.0 to 1.16.2. - [Release notes](https://github.com/expressjs/serve-static/releases) - [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md) - [Commits](expressjs/serve-static@v1.15.0...v1.16.2) --- updated-dependencies: - dependency-name: serve-static dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
| "string-width-cjs@npm:string-width@^4.2.0", "string-width@^1.0.2 || 2 || 3 || 4", string-width@^4.1.0, string-width@^4.2.0, string-width@^4.2.3: | ||
| "string-width-cjs@npm:string-width@^4.2.0": |
There was a problem hiding this comment.
This diff hunk looks to be a no-op: it's just splitting apart two copies of the same entry.
In other words, dependabot's version of Yarn seems to fail to notice that these are the same and can be coalesced.
(Same goes for the handful of other hunks later in the file.)
|
This issue probably doesn't affect us. It's in a Web server framework, which we use only within some dev dependencies: Apparently the vulnerability shows up if an attacker makes a request to the server, and the server code calls I'm not certain it can't affect us, though: possibly So we'll take the upgrade. The diff is a little messy as I commented above. The mess is harmless but would probably cause similar mess in reverse the next time we do a |
Taking this upgrade because we learned from dependabot that it fixes a security issue: zulip#5887 The issue is in a dev-only indirect dependency, and even our development tools *probably* don't trigger it. But I can't rule out that they might. The yarn.lock diff from dependabot is a bit messy, though, so here's me doing the same upgrade directly. --- Because this is an indirect dependency, `yarn upgrade serve-static` just does nothing. (Seems like a bug / misfeature in Yarn.) And I don't want to do a general `yarn upgrade` in this legacy codebase right now -- that would balloon into a larger task. So, here's a fun technique to make the upgrade in a surgical way: $ perl -i -0pe 's{^serve-static@.*?\n\K.*?^$} { version "1.16.2"\n}sm ' yarn.lock $ yarn That deletes the "version", "resolved", and other fields in the lockfile's resolution of the `serve-static` package, replacing them with just a "version" line pointing at the desired version. Then rerunning `yarn` (aka `yarn install`) starts from that version when filling back in the rest of the details.
#5889. Closing this PR in favor of that one. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/serve-static-1.16.2
branch
|
(Apart from the upgrade itself which is of possible but doubtful relevance, this PR came in handy because it turned up #5888! That's something we'll definitely want to fix.) |
Also to be explicit about why I gave this more attention than #5874: that one was a DoS, but this one (CVE-2024-43800) is RCE if it can be triggered, which is a much worse consequence. |
Taking this upgrade because we learned from dependabot that it fixes a security issue: zulip#5887 The issue is in a dev-only indirect dependency, and even our development tools *probably* don't trigger it. But I can't rule out that they might. The yarn.lock diff from dependabot is a bit messy, though, so here's me doing the same upgrade directly. --- Because this is an indirect dependency, `yarn upgrade serve-static` just does nothing. (Seems like a bug / misfeature in Yarn.) And I don't want to do a general `yarn upgrade` in this legacy codebase right now -- that would balloon into a larger task. So, here's a fun technique to make the upgrade in a surgical way: $ perl -i -0pe 's{^serve-static@.*?\n\K.*?^$} { version "1.16.2"\n}sm ' yarn.lock $ yarn That deletes the "version", "resolved", and other fields in the lockfile's resolution of the `serve-static` package, replacing them with just a "version" line pointing at the desired version. Then rerunning `yarn` (aka `yarn install`) starts from that version when filling back in the rest of the details.
Taking this upgrade because we learned from dependabot that it fixes a security issue: #5887 The issue is in a dev-only indirect dependency, and even our development tools *probably* don't trigger it. But I can't rule out that they might. The yarn.lock diff from dependabot is a bit messy, though, so here's me doing the same upgrade directly. --- Because this is an indirect dependency, `yarn upgrade serve-static` just does nothing. (Seems like a bug / misfeature in Yarn.) And I don't want to do a general `yarn upgrade` in this legacy codebase right now -- that would balloon into a larger task. So, here's a fun technique to make the upgrade in a surgical way: $ perl -i -0pe 's{^serve-static@.*?\n\K.*?^$} { version "1.16.2"\n}sm ' yarn.lock $ yarn That deletes the "version", "resolved", and other fields in the lockfile's resolution of the `serve-static` package, replacing them with just a "version" line pointing at the desired version. Then rerunning `yarn` (aka `yarn install`) starts from that version when filling back in the rest of the details.
Bumps serve-static from 1.15.0 to 1.16.2.
Release notes
Sourced from serve-static's releases.
Changelog
Sourced from serve-static's changelog.
Commits
ec9c5ec1.16.2f454d37fix(deps): encodeurl@~2.0.077a82551.16.14263f49fix(deps): [email protected]48c73971.16.00c11fadMerge commit from forkMaintainer changes
This version was pushed to npm by wesleytodd, a new releaser for serve-static since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.