react: Convert class components to function components, where trivial #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these have any custom instance methods, or lifecycle methods other than `render`, so they're nice and boring and easy. This doesn't mean all the rest of our React components will be hard to convert. These were just the (very) low-hanging fruit. :) As usual, passing -b to a git-log command is helpful to reduce noise when viewing a class-to-function-component conversion.
|
Thanks! Looks good; merging. |
gnprice
force-pushed
the
pr-easy-function-component-conversions
branch
from
6a62f07 to
2d17627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these have any custom instance methods, or lifecycle methods other than
render, so they're nice and boring and easy.This doesn't mean all the rest of our React components will be hard to convert. These were just the (very) low-hanging fruit. :)
As usual, passing -b to a git-log command is helpful to reduce noise
when viewing a class-to-function-component conversion.