-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps [nfc]: Drop resolution for node-gyp under sqlite3 #5412
Conversation
This should have been included in the recent 815d9f1; oops.
We introduced this line in a7d19c0 "deps: Force sqlite3 to use a recent node-gyp", at a time when the sqlite3 package unnecessarily required a much older version, [email protected]. There's now a sqlite3 release (which we've taken) that updates that dependency to [email protected], the same thing our resolution was requiring. So drop the resolution and let the package's own metadata govern from here. This doesn't immediately change what version we actually use anywhere. Before and after the change, `yarn why node-gyp` reports: => Found "[email protected]" info Reasons this module exists - "sqlite3" depends on it - Hoisted from "sqlite3#node-gyp" … => Found "ttf2woff2#[email protected]" info This module exists because "@vusion#webfonts-generator#ttf2woff2" depends on it.
0f3ca09
to
70b929e
Compare
LGTM, thanks! In checking this out and |
Hmm, a flake; just filed #5414 and will send a PR shortly. |
Thanks! There was a CI failure. Looks like it was all from Jest failures in one test file, all looking like this first one:
Now That's a flake we should fix, but seems clearly unrelated to these changes. I also just ran |
Ah excellent -- I was going to do the same (rather, file an issue), but you'd already done so while I was writing my comment :) |
We introduced this line in a7d19c0 "deps: Force sqlite3 to use a
recent node-gyp", at a time when the sqlite3 package unnecessarily
required a much older version, [email protected].
There's now a sqlite3 release (which we've taken) that updates that
dependency to [email protected], the same thing our resolution was
requiring. So drop the resolution and let the package's own metadata
govern from here.
This doesn't immediately change what version we actually use anywhere.
Before and after the change,
yarn why node-gyp
reports:=> Found "[email protected]"
info Reasons this module exists
…
=> Found "ttf2woff2#[email protected]"
info This module exists because "@vusion#webfonts-generator#ttf2woff2" depends on it.