deps: Temporarily use fork for @react-navigation/bottom-tabs #5368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-react-nav-bottom-tabs-fork
branch
from
8174d54 to
e2191ac
Compare
To get chrisbobbe/react-navigation@b2343cb25, which I've published to NPM in @zulip/[email protected]. It cherry-picks react-navigation/react-navigation@d87857e5d, which is a compatibility fix for RN v0.65 that React Navigation published in v6 but didn't backport to v5. So this fix will become unnecessary when we're on React Navigation 6; that's issue zulip#4936. A small handful of things went wrong when building the .d.ts files for the publish to NPM, so some TypeScript types are lost, which is fine because we don't use TypeScript. But the runtime code looks like it's updated in the ways we'd want and expect.
gnprice
force-pushed
the
pr-react-nav-bottom-tabs-fork
branch
from
e2191ac to
c0b17bd
Compare
|
Thanks! Looks good -- merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get chrisbobbe/react-navigation@b2343cb25, which I've published
to NPM in @zulip/[email protected].
It cherry-picks react-navigation/react-navigation@d87857e5d, which
is a compatibility fix for RN v0.65 that React Navigation published
in v6 but didn't backport to v5.
So this fix will become unnecessary when we're on React Navigation
6; that's issue #4936.
A small handful of things went wrong when building the .d.ts files
for the publish to NPM, so some TypeScript types are lost, which is
fine because we don't use TypeScript. But the runtime code looks
like it's updated in the ways we'd want and expect.