Move two more libdefs into .js.flow files #5314
Conversation
There was a problem hiding this comment.
Thanks @chrisbobbe! All looks good modulo two small comments below -- then please merge at will.
| declare export function useSafeAreaFrame(): Rect; | ||
| declare export function withSafeAreaInsets<P: { ... }>( | ||
| WrappedComponent: React$ComponentType<$Exact<P>>, | ||
| ): React$AbstractComponent<{| ...$Exact<P>, +ref?: React$Ref<$Exact<P>> |}, mixed>; |
There was a problem hiding this comment.
For where the (translated) TypeScript got such things as
ForwardRefExoticComponent, see
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts
nit: link to a specific commit ID, so that the link continues to work in the future and point to the same code you had in mind when you wrote this commit message.
(No need to go and forensically track down what version the author of this bit of TypeScript might have had in mind -- whatever permalink you get when you hit y on that GitHub web page is fine, if it conveys the information you're thinking of when you write the commit message.)
There was a problem hiding this comment.
Wow, TIL about y! 🙂 Thanks!
| declare export function useSafeAreaFrame(): Rect; | ||
| declare export function withSafeAreaInsets<P: { ... }>( | ||
| WrappedComponent: React$ComponentType<$Exact<P>>, | ||
| ): React$AbstractComponent<{| ...$Exact<P>, +ref?: React$Ref<$Exact<P>> |}, mixed>; |
There was a problem hiding this comment.
| ): React$AbstractComponent<{| ...$Exact<P>, +ref?: React$Ref<$Exact<P>> |}, mixed>; | |
| ): React$ComponentType<{| ...$Exact<P>, +ref?: React$Ref<$Exact<P>> |}>; |
I had a recollection that AbstractComponent could often be simplified, and went and looked it up here:
https://github.com/zulip/zulip-mobile/blob/main/docs/background/react.md
Indeed, the key line is (from react.js):
declare type React$ComponentType<-Config> = React$AbstractComponent<Config, mixed>;That's also nice because it makes the relationship between argument and return type more apparent.
NetInfoConnectedDetails is inexact; so, make the object type that it contributes to (at NetInfoConnectedState.details) inexact. Also, the type param D is often inexact; that's another reason to make the outer object inexact. As a consequence, Flow v0.149 would rightly complain about possibly trying to `logging.warn` non-JSONable contents of the object. So, comment about that.
To see that only whitespace is changed, view the diff with git diff -w
For where the (translated) TypeScript got such things as ForwardRefExoticComponent, see https://github.com/DefinitelyTyped/DefinitelyTyped/blob/6d452c708/types/react/index.d.ts
chrisbobbe
force-pushed
the
pr-two-more-libdefs
branch
from
0048b30 to
044733e
Compare
|
Thanks for the review! Merged, with those fixes. |
Following #5311, which did this for
react-intl. Now we do:react-native-safe-area-context@react-native-community/netinfo