react-intl types: Move definitions out of flow-typed libdef #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Mar 31, 2022
There was a problem hiding this comment.
Thanks @chrisbobbe! This all looks good except one item below.
flow-typed/react-intl_vx.x.x.js
Outdated
| {| | ||
| formats: mixed, | ||
| messages: mixed, | ||
| timeZone: mixed, |
There was a problem hiding this comment.
This isn't quite right -- to match the intended behavior it needs to be timeZone?: mixed, unfortunately:
* A limitation: this implementation can't tell which properties are
* *optional* in T, i.e. spelled with `?:`, as in `foo?: number`. Instead,
* properties in the result will be optional or required based on how they
* are in U. To avoid confusion, be sure to make the same properties
* optional in U as are optional in T.
I.e., IntlConfig has timeZone optional, so this needs to have timeZone optional as well in order to make it optional in the result.
(Similarly some other properties.)
There was a problem hiding this comment.
Thanks for catching this! I think I've got them all in the new revision.
We moved this stuff to our types/@react-navigation/ in zulip#5263, and we already have a line for that in this file.
This doesn't actually improve Flow coverage or change any types; both Omit and Exclude are utility types in TypeScript that Flow doesn't have. But in the original TypeScript, the use of Exclude for these was a mistake; they should have been Omit; see discussion at zulip#5308 (comment) We're about to go through all uses of Omit and replace them with something that works; these will then be fixed.
…onfig As suggested by Greg at zulip#5308 (comment)
The React$Component type asks for a type argument, and one wasn't getting passed. Instead of working out what exactly to pass, use this form, which is more concise and probably more appropriate anyway.
…lity As suggested by Greg: zulip#5308 (comment) This definition is copied from our src/generics.js. When we move this libdef to a .js.flow file, we'll deduplicate the definition by importing it from src/generics.
…lity As suggested by Greg: zulip#5308 (comment)
To see that only whitespace is changed, view the diff with git diff -w
chrisbobbe
force-pushed
the
pr-react-intl-js-flow
branch
from
84a2abd to
96524ab
Compare
|
Thanks for the review! Revision pushed. |
|
Thanks! Looks good -- merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers Greg's responses starting from #5308 (comment) and moves the react-intl libdef into a .js.flow file.