initial data types: Add TODOs to update to modern user_settings object
#5299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A search in the docs comes up empty for these: https://zulip.com/api/register-queue
And mark write-only (with the contravariance sigil, `-`) the deprecated properties that appear in our types but that we're not currently using, so that we won't accidentally start using them. This should be all of them. I checked all 36 results of the search term [did not include user_settings_object] on https://zulip.com/api/register-queue on 2022-03-15. Several of the 36 were properties that we don't use and that don't appear in our types at all. (No use adding those, I think, just for them to be removed when we do the migration.) Related: zulip#4933
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And mark write-only (with the contravariance sigil,
-) thedeprecated properties that appear in our types but that we're not
currently using, so that we won't accidentally start using them.
This should be all of them. I checked all 36 results of the search
term [did not include user_settings_object] on
https://zulip.com/api/register-queue on 2022-03-15. Several of the
36 were properties that we don't use and that don't appear in our
types at all. (No use adding those, I think, just for them to be
removed when we do the migration.)
Related: #4933