ios: Drop iOS 11 support; require iOS 12.1+. #4664

chrisbobbe · 2021-04-15T15:02:47Z

ios: Drop iOS 11 support; require iOS 12.1+.

We'd like to use Array.prototype.flatMap, which it seems won't
work in React Native on iOS until iOS 12. This was noted in a
comment [1] on facebook/react-native#26283. While the reasoning
there wasn't as thorough as we'd like, we looked closer [2], and we
believe the conclusion is correct.

A fresh look at iOS installations by platform (or the proxy we use
for that, anyway) [3] shows iOS 11 usage is 0.1% of our iOS usage,
so this should be fine to do. Also, 5.9% of our iOS users are on iOS
<= 13, so graceful degradation at that level is fine.

[1] facebook/react-native#26283 (comment)
[2] https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1163034
[3] https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1164857

chrisbobbe · 2021-04-16T18:41:53Z

(For comparison, c953bc3 was the commit in which we dropped iOS 10 support.)

gnprice · 2021-04-16T21:13:47Z

Thanks @chrisbobbe ! Small comments:

Let's also update tools/generate-webview-js; see 84fae48. I think it won't actually change the output (because our minimum Chrome version is rather older), but good to keep in sync.
In the "history" entry in platform-versions.md, I've liked having links to the chat threads where we made the decision; sometimes handy for looking those up, and easy to do at the time we're making the change.
In the commit message: I don't feel like our reasoning on the "RN uses the system JSC" point is totally thorough either, so I'd just drop that bit.

This will let us make `prevMessage` non-stateful, which we'll do in the next commit, and probably make way for further tidying of this code. Requires dropping iOS 11 support; see zulip#4664.

chrisbobbe · 2021-04-16T22:26:31Z

Let's also update tools/generate-webview-js; see 84fae48. I think it won't actually change the output (because our minimum Chrome version is rather older), but good to keep in sync.

Goodness, right! Thanks for the reminder; I see you carefully made sure there were bidirectional comments, and I looked right past them, only focusing on what I'd done in my own commit last time. 🙂

New revision pushed.

WesleyAC

Two minor comments, but looks good other than those — feel free to merge once you've fixed them.

WesleyAC · 2021-04-20T15:05:32Z

docs/architecture/platform-versions.md

@@ -91,11 +91,15 @@ History:
 * We dropped iOS 10 support in 2020-10. It was 0.3% of iOS users who
  tried Zulip, and we wanted to use a feature introduced in iOS 11,
  called "named colors".
+* We [dropped iOS 11 support][] in 2021-04. It was 0.1% of iOS users


nit: the empty [] doesn't do anything here, I don't think

WesleyAC · 2021-04-20T15:10:18Z

docs/architecture/platform-versions.md

@@ -91,11 +91,15 @@ History:
 * We dropped iOS 10 support in 2020-10. It was 0.3% of iOS users who
  tried Zulip, and we wanted to use a feature introduced in iOS 11,
  called "named colors".
+* We [dropped iOS 11 support][] in 2021-04. It was 0.1% of iOS users
+  who tried Zulip. We started iOS 12 support at 12.1 because Xcode's
+  dropdown for "Deployment Target" didn't have a 12.0.


Could you add a comment here like:



Alternatively, we might want to consider just having fewer places where we keep this information :) I'd be fine with removing it from docs/developer-guide.md altogether, or keeping a link to this doc but not explicitly writing down the versions.

A fresh look at iOS installations by platform (or the proxy we use for that, anyway) [1] shows iOS 11 usage is 0.1% of our iOS usage, so we're well into the time when this is OK to do. Also, with 1.5% of users on 12 and older, iOS 12 is solidly in the range where we'd be happy to drop it, if we find things don't work or require effort to keep working there. 5.9% of our iOS users are on iOS <= 13, so graceful degradation at that level is fine. [1] https://chat.zulip.org/#narrow/stream/48-mobile/topic/platform.20versions/near/1164857

…sions.

chrisbobbe · 2021-04-20T21:24:13Z

Thanks for the review! Merged, with those tweaks.

gnprice · 2021-04-20T22:30:05Z

Thanks!

In the commit message: I don't feel like our reasoning on the "RN uses the system JSC" point is totally thorough either, so I'd just drop that bit.

FTR, what I meant here (and, rereading, I see this was thoroughly unclear in my comment) was that the reasoning that we want to use flatMap and we believe that's only available on iOS 12+ is fine -- just that I'd like to drop the part about how the reasoning in that other comment wasn't thorough.

This will let us make `prevMessage` non-stateful, which we'll do in the next commit, and probably make way for further tidying of this code. Requires dropping iOS 11 support; see zulip#4664.

This will let us make `prevMessage` non-stateful, which we'll do in the next commit, and probably make way for further tidying of this code. Possible now that we've dropped iOS 11 support; that was zulip#4664.

chrisbobbe added the a-iOS label Apr 15, 2021

chrisbobbe requested a review from gnprice April 15, 2021 15:02

chrisbobbe force-pushed the pr-drop-ios-11 branch from b3cb7bd to 67abe98 Compare April 16, 2021 18:38

chrisbobbe changed the title ~~[DRAFT] ios: Drop iOS 11 support; require iOS 12.1+.~~ ios: Drop iOS 11 support; require iOS 12.1+. Apr 16, 2021

chrisbobbe requested a review from WesleyAC April 16, 2021 18:39

chrisbobbe marked this pull request as ready for review April 16, 2021 18:39

chrisbobbe mentioned this pull request Apr 16, 2021

Clarify some message-list code (part 2). #4670

Merged

chrisbobbe force-pushed the pr-drop-ios-11 branch from 67abe98 to 4e13ee3 Compare April 16, 2021 22:26

WesleyAC approved these changes Apr 20, 2021

View reviewed changes

chrisbobbe force-pushed the pr-drop-ios-11 branch from 4e13ee3 to 23e63c3 Compare April 20, 2021 21:22

chrisbobbe added 2 commits April 20, 2021 17:23

docs [nfc]: Remind about developer-guide when dropping platform ver…

7336fb1

…sions.

chrisbobbe force-pushed the pr-drop-ios-11 branch from 23e63c3 to 7336fb1 Compare April 20, 2021 21:23

chrisbobbe merged commit 7336fb1 into zulip:master Apr 20, 2021

chrisbobbe deleted the pr-drop-ios-11 branch June 23, 2021 17:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ios: Drop iOS 11 support; require iOS 12.1+. #4664

ios: Drop iOS 11 support; require iOS 12.1+. #4664

chrisbobbe commented Apr 15, 2021 •

edited

Loading

chrisbobbe commented Apr 16, 2021

gnprice commented Apr 16, 2021

chrisbobbe commented Apr 16, 2021 •

edited

Loading

WesleyAC left a comment

WesleyAC Apr 20, 2021

WesleyAC Apr 20, 2021

chrisbobbe commented Apr 20, 2021

gnprice commented Apr 20, 2021

ios: Drop iOS 11 support; require iOS 12.1+. #4664

ios: Drop iOS 11 support; require iOS 12.1+. #4664

Conversation

chrisbobbe commented Apr 15, 2021 • edited Loading

chrisbobbe commented Apr 16, 2021

gnprice commented Apr 16, 2021

chrisbobbe commented Apr 16, 2021 • edited Loading

WesleyAC left a comment

Choose a reason for hiding this comment

WesleyAC Apr 20, 2021

Choose a reason for hiding this comment

WesleyAC Apr 20, 2021

Choose a reason for hiding this comment

chrisbobbe commented Apr 20, 2021

gnprice commented Apr 20, 2021

chrisbobbe commented Apr 15, 2021 •

edited

Loading

chrisbobbe commented Apr 16, 2021 •

edited

Loading