Prepare to remove several definitions in navActions.
#4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make this possible, we also tweak `useNavigation` in the libdef to make it generic.
I have *one* email notification about this log, from March 20, 2020, but it's so old that it's already been cleared out of Sentry's storage, it seems (the ID is a93f2c810f6647de93794db102f12488). And searching Sentry for other events I might not have gotten an email notification about...turns up empty.
No data was being grabbed with selectors, and `dispatch` wasn't being used.
|
Looks good, thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for part of #4417.
This PR does those easy conversions to Hooks-based components. It also adds a type-wrapper and makes a tweak to the react-navigation libdef so that our use of
useNavigationwill be well-typed.