Upgrade @zulip/shared to new, simplified typing_status API #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Pretend this is a "draft PR": immediately after posting it I remembered that feature exists, but lolgithub it's not possible to switch it to that.) |
The shared code from the webapp now itself provides the interface we'd constructed with this wrapper -- including jsdoc with all the same information that was in the wrapper's jsdoc (indeed largely copied from it.) So, we get to cut out the wrapper entirely.
gnprice
force-pushed
the
typing-status
branch
from
7ea3f45 to
0890aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Draft, pending review/merge/upload of zulip/zulip#13315 .)
The shared code from the webapp now itself provides the interface we'd
constructed with this wrapper -- including jsdoc with all the same
information that was in the wrapper's jsdoc (indeed largely copied
from it.) So, we get to cut out the wrapper entirely.