Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support downgrading to a long-lived event queue #3916

Open
chrisbobbe opened this issue Feb 19, 2020 · 2 comments
Open

Support downgrading to a long-lived event queue #3916

chrisbobbe opened this issue Feb 19, 2020 · 2 comments
Labels
a-data-sync Zulip's event system, event queues, staleness/liveness api migrations blocked on other work To come back to after another related PR, or some other task. P1 high-priority

Comments

@chrisbobbe
Copy link
Contributor

chrisbobbe commented Feb 19, 2020

@timabbott mentions on czo that zulip/zulip#12926 is the PR thread tracking a server feature for the ability to downgrade to a long-lived event queue that ignores high-traffic events.

This would cover #1804 by making it unnecessary to fetch all users at startup; long initial load times are a common problem for users (see also the czo link, above), but I've made a new issue because there are separate benefits and implementation details to consider.

Unrecognized events will be ignored all the way back to mobile commit d2836e1, 2017-03-11, v1.0.11 (see discussion). Progress on feature detection via version number parsing is underway at #3839; see also the discussion about a feature level integer in, e.g., the /server_settings response, which we'll want to switch to when possible.

@gnprice
Copy link
Member

gnprice commented Feb 20, 2020

Unrecognized events will be ignored all the way back to mobile commit d2836e1, 2017-03-11, v1.0.11 (see discussion).

It looks like that reference was about events with the update_message type, but with a new field.

We do ignore events of unexpected type (in responseToActions in eventActions.js), though, and I think we have for a long time. Fortunately also it doesn't matter how long we have (or even if we already do or not), because this will be a feature that new clients opt into.

@gnprice gnprice added the a-data-sync Zulip's event system, event queues, staleness/liveness label Sep 16, 2021
@gnprice gnprice changed the title [Pending server work] Support downgrading to a long-lived event queue. Support downgrading to a long-lived event queue Apr 1, 2022
@gnprice
Copy link
Member

gnprice commented Apr 1, 2022

This blocks on #4841 and #3408.

Then when the blockers are cleared, the work of this issue will be to a large extent on the server, as well as in the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-data-sync Zulip's event system, event queues, staleness/liveness api migrations blocked on other work To come back to after another related PR, or some other task. P1 high-priority
Projects
None yet
Development

No branches or pull requests

2 participants