Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete for @-mentions should prioritize users I interact with #2603

Open
gnprice opened this issue Jun 1, 2018 · 6 comments
Open

Autocomplete for @-mentions should prioritize users I interact with #2603

gnprice opened this issue Jun 1, 2018 · 6 comments
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending @zulip/shared Good spots to share code with the webapp

Comments

@gnprice
Copy link
Member

gnprice commented Jun 1, 2018

For example, if on chat.zulip.org I type @tim, I get 5 suggestions for users I've never heard of -- more than enough to fill the visible list -- before I see Tim Abbott. Similarly if I type @tab (the start of the localpart/username of his email address), or @abb.

We should follow the same logic the web app has for this. See typeahead_helper.js, particularly sort_for_at_mentioning and its subroutines.

@jainkuniya
Copy link
Member

Hmm, I have worked on this logic few months back. That seems be only useful only for smaller realm.

@zulipbot claim

@gnprice
Copy link
Member Author

gnprice commented Jun 2, 2018

Great, thanks!

That seems be only useful only for smaller realm.

I think this may be what you mean already, but just to be explicit: I think the logic we need and don't yet have, which the web app has, gets more and more necessary as a Zulip org (realm) grows. Our existing logic is potentially enough for small realms, but users of chat.zulip.org, and I think a lot of mid-size realms much smaller than that one, will be glad to see this implemented 😄

@timabbott
Copy link
Member

One thing worth mentioning is that the logic of sort_for_at_mentioning is based on the recent_senders data structure, which comes from data for the most recent 1200 messages that we fetch in the webapp.

We don't do the same fetch in mobile, so while we can probably use a similar algorithm, I'm not sure we have the data stored effectively in the app currently to do this that same way.

@gnprice
Copy link
Member Author

gnprice commented Jun 2, 2018

Sure. There are a lot of elements of that algorithm that should be useful independently of each other -- so I'd like to first merge all the ones we can do without additional data.

After that, we can problem-solve how best to do the rest. (For example, there might be appropriate summaries the server could provide us -- potentially even some which would improve ranking quality for the web app beyond what it currently does.)

@borisyankov
Copy link
Contributor

We only fetch the last 100 PM/group messages which can be used for some prioritization, but to a much smaller extent than the web app.
Getting aggregates of last conversations was discussed several times before. If we have this we can use that data.

@chrisbobbe
Copy link
Contributor

I believe this will be fixed with a fix for #3902.

@gnprice gnprice added @zulip/shared Good spots to share code with the webapp a-compose/send Compose box, autocomplete, camera/upload, outbox, sending and removed zz-in progress labels Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending @zulip/shared Good spots to share code with the webapp
Projects
None yet
Development

No branches or pull requests

6 participants