-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete for @-mentions should prioritize users I interact with #2603
Comments
Hmm, I have worked on this logic few months back. That seems be only useful only for smaller realm. @zulipbot claim |
Great, thanks!
I think this may be what you mean already, but just to be explicit: I think the logic we need and don't yet have, which the web app has, gets more and more necessary as a Zulip org (realm) grows. Our existing logic is potentially enough for small realms, but users of chat.zulip.org, and I think a lot of mid-size realms much smaller than that one, will be glad to see this implemented 😄 |
One thing worth mentioning is that the logic of We don't do the same fetch in mobile, so while we can probably use a similar algorithm, I'm not sure we have the data stored effectively in the app currently to do this that same way. |
Sure. There are a lot of elements of that algorithm that should be useful independently of each other -- so I'd like to first merge all the ones we can do without additional data. After that, we can problem-solve how best to do the rest. (For example, there might be appropriate summaries the server could provide us -- potentially even some which would improve ranking quality for the web app beyond what it currently does.) |
We only fetch the last 100 PM/group messages which can be used for some prioritization, but to a much smaller extent than the web app. |
I believe this will be fixed with a fix for #3902. |
For example, if on chat.zulip.org I type
@tim
, I get 5 suggestions for users I've never heard of -- more than enough to fill the visible list -- before I see Tim Abbott. Similarly if I type@tab
(the start of the localpart/username of his email address), or@abb
.We should follow the same logic the web app has for this. See
typeahead_helper.js
, particularlysort_for_at_mentioning
and its subroutines.The text was updated successfully, but these errors were encountered: