-
-
Notifications
You must be signed in to change notification settings - Fork 656
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use a "Storyboard" instead of an "XIB", as has apparently [1] been required since 2020-04-30. A change like this is part of the RN v0.62 -> v0.63 changes to the template app [2], corresponding to facebook/react-native@33b3a1a14. Since it's simple to do (especially after adding the "Brand" color set in a recent commit), make it be a solid brand-color screen instead of solid white. It should match the color of our `LoadingScreen`, which is often the first thing that displays when you open the app. The changes in this commit coincide with the iOS-specific instructions from `expo-launch-screen` for how to set up a launch screen [3], with some exceptions: - We don't actually go on to set up `expo-launch-screen`; we currently don't intend to [4]. - We don't do anything marked "optional". - We don't add an image to the launch screen; we can do that later if we want to. - We set the `Storyboard ID` to `LaunchScreenViewController`, not `SplashScreenViewController`. Apple regularly calls the thing a "launch screen", not a "splash screen". [1] https://developer.apple.com/news/?id=03042020b [2] https://react-native-community.github.io/upgrade-helper/?from=0.62.2&to=0.63.3 [3] https://github.com/expo/expo/tree/master/packages/expo-splash-screen#manual-configuration [4] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/React.20Navigation.20v5/near/1042794 [5] https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/launch-screen/
- Loading branch information
1 parent
575be42
commit 78a62b2
Showing
3 changed files
with
40 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="17156" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" launchScreen="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES" initialViewController="01J-lp-oVM"> | ||
| <device id="retina4_7" orientation="portrait" appearance="light"/> | ||
| <dependencies> | ||
| <deployment identifier="iOS"/> | ||
| <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="17126"/> | ||
| <capability name="Named colors" minToolsVersion="9.0"/> | ||
| <capability name="Safe area layout guides" minToolsVersion="9.0"/> | ||
| <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/> | ||
| </dependencies> | ||
| <scenes> | ||
| <!--View Controller--> | ||
| <scene sceneID="EHf-IW-A2E"> | ||
| <objects> | ||
| <viewController storyboardIdentifier="LaunchScreenViewController" id="01J-lp-oVM" sceneMemberID="viewController"> | ||
| <view key="view" contentMode="scaleToFill" id="2Zo-eZ-ckx"> | ||
| <rect key="frame" x="0.0" y="0.0" width="375" height="667"/> | ||
| <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/> | ||
| <viewLayoutGuide key="safeArea" id="yBM-Xp-f8I"/> | ||
| <color key="backgroundColor" name="Brand"/> | ||
| </view> | ||
| </viewController> | ||
| <placeholder placeholderIdentifier="IBFirstResponder" id="iYj-Kq-Ea1" userLabel="First Responder" sceneMemberID="firstResponder"/> | ||
| </objects> | ||
| <point key="canvasLocation" x="52.173913043478265" y="375"/> | ||
| </scene> | ||
| </scenes> | ||
| <resources> | ||
| <namedColor name="Brand"> | ||
| <color red="0.31764705882352939" green="0.76078431372549016" blue="0.68627450980392157" alpha="1" colorSpace="custom" customColorSpace="sRGB"/> | ||
| </namedColor> | ||
| </resources> | ||
| </document> |
This file was deleted.
Oops, something went wrong.