Skip to content

Commit

Permalink
deps [nfc]: Drop resolution for node-gyp under sqlite3
Browse files Browse the repository at this point in the history
We introduced this line in a7d19c0 "deps: Force sqlite3 to use a
recent node-gyp", at a time when the sqlite3 package unnecessarily
required a much older version, [email protected].

There's now a sqlite3 release (which we've taken) that updates that
dependency to [email protected], the same thing our resolution was
requiring.  So drop the resolution and let the package's own metadata
govern from here.

This doesn't immediately change what version we actually use anywhere.
Before and after the change, `yarn why node-gyp` reports:

=> Found "[email protected]"
info Reasons this module exists
   - "sqlite3" depends on it
   - Hoisted from "sqlite3#node-gyp"
…
=> Found "ttf2woff2#[email protected]"
info This module exists because "@vusion#webfonts-generator#ttf2woff2" depends on it.
  • Loading branch information
gnprice authored and chrisbobbe committed Jun 13, 2022
1 parent ddba24b commit 70b929e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@
"resolutions": {
"jest-expo/react-test-renderer": "17.0.2",
"prettier-eslint-cli/prettier-eslint": "^15.0.0",
"react-native/use-subscription": ">=1.0.0 <1.6.0",
"sqlite3/**/node-gyp": "^8"
"react-native/use-subscription": ">=1.0.0 <1.6.0"
}
}
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8807,7 +8807,7 @@ node-fetch@^1.0.1:
encoding "^0.1.11"
is-stream "^1.0.1"

[email protected], node-gyp@^8:
[email protected]:
version "8.4.1"
resolved "https://registry.yarnpkg.com/node-gyp/-/node-gyp-8.4.1.tgz#3d49308fc31f768180957d6b5746845fbd429937"
integrity sha512-olTJRgUtAb/hOXG0E93wZDs5YiJlgbXxTwQAFHyNlRsXQnYzUaF2aGgujZbw+hR8aF4ZG/rST57bWMWD16jr9w==
Expand Down

0 comments on commit 70b929e

Please sign in to comment.