From 10622c6a3be3b3843c3224ed354fa5c234928721 Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Wed, 19 Aug 2020 15:04:42 -0700 Subject: [PATCH] render test: Use representative `realm` value for `messageTypingAsHtml`. It looks like this was trying to test that the sequence `&<` gets escaped correctly. But we're already testing that for the user's `email` and `avatar_url`, and I don't think we expect a realm URL to contain that sequence. When we start making `getFullUrl` use the URL constructor in an upcoming commit, this test would have thrown an invalid URL error. At that commit, we'll be sure to test manually, noting any invalid URL errors we see at runtime, and address them. --- src/webview/html/__tests__/render-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/webview/html/__tests__/render-test.js b/src/webview/html/__tests__/render-test.js index 7c5d4907e03..365af1b6fa9 100644 --- a/src/webview/html/__tests__/render-test.js +++ b/src/webview/html/__tests__/render-test.js @@ -11,6 +11,6 @@ describe('typing', () => { email: `${name}@example.com`, }; - expect(messageTypingAsHtml('&