Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of thumbnails #799

Closed
alya opened this issue Jul 10, 2024 · 1 comment · Fixed by #820
Closed

Make use of thumbnails #799

alya opened this issue Jul 10, 2024 · 1 comment · Fixed by #820
Assignees
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-lightbox The lightbox / image-viewer screen server-9 Things new in Zulip Server 9.0

Comments

@alya
Copy link
Collaborator

alya commented Jul 10, 2024

In zulip/zulip#16210, we're implementing thumbnailing for uploaded images.

We should use thumbnails in the mobile app. In particular, the message view should show thumbnails, while the lightbox should download the full-scale images.

Blockers:

@alya alya added a-msglist The message-list screen, except what's label:a-content server-9 Things new in Zulip Server 9.0 labels Jul 10, 2024
@alya alya added this to Flutter app Jul 10, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jul 10, 2024
@gnprice gnprice added a-content Parsing and rendering Zulip HTML content, notably message contents a-lightbox The lightbox / image-viewer screen and removed a-msglist The message-list screen, except what's label:a-content labels Jul 10, 2024
@gnprice
Copy link
Member

gnprice commented Jul 16, 2024

For implementing this feature, the pieces we'll need are:

  • There's a new bit of HTML for a placeholder where the server is preparing a thumbnail.

    We'll need to parse that in lib/model/content.dart, and then build an appropriate widget to show the desired UI: a spinner similar to what Zulip web shows.

  • In images in message content, the HTML will look very similar but the two image URLs that appear (one at the href of an enclosing a, one at the src of an img) will start being different from each other: one is the thumbnail and one the original image.

    We'll need to start tracking both those URLs in the content parser. Then we'll use one for the image in the message list, and the other for the lightbox.

    The "Copy link" feature in the lightbox should also get the original full-size image. I think this will happen automatically given a natural implementation of the rest of the feature, but it should be included as one of the test cases.

rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 17, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 18, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 18, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 18, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 19, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents a-lightbox The lightbox / image-viewer screen server-9 Things new in Zulip Server 9.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants