Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type in user settings for zowe.settings.version #2166

Closed
Tracked by #2206
phaumer opened this issue Mar 1, 2023 · 3 comments · Fixed by #2286
Closed
Tracked by #2206

Incorrect type in user settings for zowe.settings.version #2166

phaumer opened this issue Mar 1, 2023 · 3 comments · Fixed by #2286
Assignees
@traeok
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases

Comments

@phaumer
Copy link
Member

phaumer commented Mar 1, 2023

Describe the bug

Zowe Explorer writes an invalid version number in 2.6.1 into the user settings file. The value should remain an integer 2 as the setting had not changed/do not require additional migration since 1.x.

2023-03-01_13-30-41

To Reproduce

Expected behavior

Keep the 2 integer indicating that a migration from v1 to v2 had happened.

Screenshots

Desktop (please complete the following information):

  • OS:
  • Zowe Explorer Version:
  • (Optional) Zowe CLI Version:
  • (Optional) Are you using Secure Credential Store?

Additional context
@phaumer phaumer added the bug Something isn't working label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Thank you for creating a bug report. If you haven't already, please ensure you have provided steps to reproduce it and as much context as possible.

@phaumer
Copy link
Member Author

phaumer commented Mar 1, 2023

@SG-A47 filed your issue here.

@phaumer phaumer mentioned this issue Mar 1, 2023
Closed
@zFernand0 zFernand0 added priority-low Legit issue but cosmetic or nice-to-have severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases labels Mar 7, 2023
@phaumer
Copy link
Member Author

phaumer commented Mar 23, 2023

@zFernand0 @rudyflores I would propose increasing the priority as people will get this message every time there is a new release now and there no reason to use any other value than 2, unless we introduce more breaking changes.

2023-03-22_18-01-53

@zFernand0 zFernand0 added priority-medium Not functioning - next quarter if capacity permits and removed priority-low Legit issue but cosmetic or nice-to-have labels Mar 23, 2023
@JillieBeanSim JillieBeanSim mentioned this issue Mar 28, 2023
Closed
27 tasks
@traeok traeok self-assigned this May 15, 2023
@traeok traeok mentioned this issue May 17, 2023
Merged
11 tasks
@traeok traeok linked a pull request May 23, 2023 that will close this issue
fix(settings): Coerce zowe.settings.version to an integer #2286
Merged
11 tasks
@JTonda JTonda closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@traeok traeok

Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(settings): Coerce zowe.settings.version to an integer zowe/zowe-explorer-vscode
4 participants
@phaumer @JTonda @zFernand0 @traeok