Failing unit tests present in master on Windows

[ghost]

I ran npm run test:unit today in one of my branches and found that these tests were failing for me on windows:

FAIL  packages\imperative\__tests__\plugins\utilities\npm-interface\uninstall.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'prototype' of undefined

      at patch (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:166:54)
      at Object.<anonymous> (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:27:18)
      at node_modules/npm/lib/npm.js:19:13
      at Object.<anonymous> (node_modules/npm/lib/npm.js:490:3)

 FAIL  packages\imperative\__tests__\plugins\utilities\npm-interface\update.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'prototype' of undefined

      at patch (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:166:54)
      at Object.<anonymous> (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:27:18)
      at node_modules/npm/lib/npm.js:19:13
      at Object.<anonymous> (node_modules/npm/lib/npm.js:490:3)

 FAIL  packages\imperative\__tests__\plugins\utilities\npm-interface\install.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'prototype' of undefined

      at patch (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:166:54)
      at Object.<anonymous> (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:27:18)
      at node_modules/npm/lib/npm.js:19:13
      at Object.<anonymous> (node_modules/npm/lib/npm.js:490:3)

Summary of all failing tests
 FAIL  packages\imperative\__tests__\plugins\utilities\npm-interface\uninstall.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'prototype' of undefined

      at patch (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:166:54)
      at Object.<anonymous> (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:27:18)
      at node_modules/npm/lib/npm.js:19:13
      at Object.<anonymous> (node_modules/npm/lib/npm.js:490:3)

 FAIL  packages\imperative\__tests__\plugins\utilities\npm-interface\update.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'prototype' of undefined

      at patch (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:166:54)
      at Object.<anonymous> (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:27:18)
      at node_modules/npm/lib/npm.js:19:13
      at Object.<anonymous> (node_modules/npm/lib/npm.js:490:3)

 FAIL  packages\imperative\__tests__\plugins\utilities\npm-interface\install.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'prototype' of undefined

      at patch (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:166:54)
      at Object.<anonymous> (node_modules/npm/node_modules/graceful-fs/graceful-fs.js:27:18)
      at node_modules/npm/lib/npm.js:19:13
      at Object.<anonymous> (node_modules/npm/lib/npm.js:490:3)


Test Suites: 3 failed, 74 passed, 77 total

So I switched to master to confirm if it was me and I unfortunately saw the same errors. Looking at the error it looks to have been introduced by #75. @nurra01 could you take a look at this and get a fix to master ASAP?

Interesting that you do no see this behavior on the build machine, that's why I didn't catch it. I just made the assumption that you were developing on a windows machine so you would be running a sanity check on windows, I should have run the tests as well on my machine...my bad 🙁

[ghost]

So I've updated my node from 10.6.0 to 10.9.0 and the issue seems to have gone away.

@nurra01 are these messages expected in the output of the tests?

info error reading version SyntaxError: Unexpected token u in JSON at position 0 while parsing near 'undefined'

If these are expected then I am fine with closing this issue as it seems to be related to a node version.

[nurra01]

@AHumanFromCA These messages are coming from NPM's side, it tries to find package.json file and parse it. You can find it in node_modules/npm/lib/npm.js line 83. I cannot get rid of that like NPM warning which we have.
var j = parseJSON(fs.readFileSync(
path.join(__dirname, '../package.json')) + '')

[ghost]

Hey @nurra01,

So are you saying that these messages are expected and the tests are still operating as expected?

[nurra01]

@AHumanFromCA yes

[ghost]

Updating node from 10.6 to 10.9 fixed the issue, closing.