Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

Uninstall command still are dependent on global npm #101

Closed
ghost opened this issue Nov 1, 2018 · 0 comments · Fixed by #116
Closed

Uninstall command still are dependent on global npm #101

ghost opened this issue Nov 1, 2018 · 0 comments · Fixed by #116
Labels
bug Something isn't working plugins This issue involves the Plugin Facility

Comments

@ghost
Copy link

ghost commented Nov 1, 2018

As part of #75, we were trying to remove the need for npm to be installed globally so clis could make a bundled executable. It looks like we missed some plugin commands.

The uninstall command still uses global.

const execOutput = execSync(`npm uninstall "${npmPackage}" --prefix ${PMFConstants.instance.PLUGIN_INSTALL_LOCATION} -g`, {
cwd : PMFConstants.instance.PMF_ROOT,
stdio: pipe
});

@ghost ghost added bug Something isn't working plugins This issue involves the Plugin Facility labels Nov 1, 2018
@ghost ghost changed the title Update and Uninstall command still are dependent on global npm Uninstall command still are dependent on global npm Nov 1, 2018
@nurra01 nurra01 mentioned this issue Nov 15, 2018
@ghost ghost closed this as completed in #116 Nov 16, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working plugins This issue involves the Plugin Facility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants